"Expand" addon import to include a generated APL

Open
  • Is something wrong?
#2,951 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@scamille is already working on this.

Since Oct 10, 2016.

Assessment

This issue has not been assessed yet.

Description

enhancement GUI help wanted

I see a lot of people asking how they disable potions, flasks, food, etc when importing their character from the addon. Doing so is pretty inelegant since you basically have to simulate first, then grab the APL from the profile section of the HTML report which isn't very intuitive. Some people instead take the APL from the sample profiles which causes issues with trinket usage or anything else dynamically generated based on the actor's gear.

Not sure how the feature would work, but some way for simulationcraft to automatically expand the imported copypasta from the addon to include a default action list. Perhaps the addon can have a particularly comment denoting addon import, and then the GUI would check for that comment whenever the simulate tab is pasted into, remove it, and insert the generated APL.

Dominant language
C++
Stars
1.6k
Forks
789
Avg merge
13h 25m
Merged PRs (30d)
52

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simulationcraft/simc

All issues in simulationcraft/simc

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.