Sign in with GitHub and GitLab

Open
#250 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
angular, typescript

Research direction

Start by reading the identity work in M2.2 and tracing the sign-in and sign-up buttons in the web UI to their authentication entry points. Then identify where instance settings and second-factor checks are handled. Done means linked, verified GitHub and GitLab identities can sign in, unlinked or unverified identities are refused, and the browser suite covers both buttons.

Written by the indexing model from the issue text.

Description

priority:P1 security-review task track:control-plane track:web
Track

C: control plane, W: web UI

Scope
  • OAuth sign-in with GitHub and GitLab behind the buttons already on the sign-in and sign-up screens (they now say "coming").
  • Link an external identity to an existing account only after password and second-factor proof; never create an account from an unverified provider email.
  • Instance setting to enable each provider (design: Settings → External sign-in).
Acceptance criteria

A user signs in with GitHub or GitLab into an account linked beforehand; an unlinked or unverified identity is refused; the browser suite covers both buttons.

Depends on

M2.2 (identity). Distinct from M3.1 (Git providers for repositories) and M8.1 (generic OIDC).

Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 17m
Merged PRs (30d)
197

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from shipkeepdev/shipkeep

All issues in shipkeepdev/shipkeep

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.