Sign in with GitHub and GitLab

未关闭
  • 哪里不对？
#250 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
42/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
angular, typescript
领域
authentication, backend, frontend

调研方向

Start by reading the identity work in M2.2 and tracing the sign-in and sign-up buttons in the web UI to their authentication entry points. Then identify where instance settings and second-factor checks are handled. Done means linked, verified GitHub and GitLab identities can sign in, unlinked or unverified identities are refused, and the browser suite covers both buttons.

由索引模型根据 Issue 内容生成。

描述

priority:P1 security-review task track:control-plane track:web
Track

C: control plane, W: web UI

Scope
  • OAuth sign-in with GitHub and GitLab behind the buttons already on the sign-in and sign-up screens (they now say "coming").
  • Link an external identity to an existing account only after password and second-factor proof; never create an account from an unverified provider email.
  • Instance setting to enable each provider (design: Settings → External sign-in).
Acceptance criteria

A user signs in with GitHub or GitLab into an account linked beforehand; an unlinked or unverified identity is refused; the browser suite covers both buttons.

Depends on

M2.2 (identity). Distinct from M3.1 (Git providers for repositories) and M8.1 (generic OIDC).

主要语言
TypeScript
星标
2
派生
1
平均合并
7 小时 17 分钟
30 天内合并 PR
197

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

shipkeepdev/shipkeep 的其他 Issue

查看 shipkeepdev/shipkeep 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。