Tests: accept the PostgreSQL 18 code for ON DELETE RESTRICT

Open Beginner friendly
  • Is something wrong?
#212 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
postgresql, typescript
Domain
databases, testing

Research direction

Start with the failing assertions in fleet-tenant.integration.spec.ts and tenant-schema.integration.spec.ts, then check how they match the PostgreSQL error code for ON DELETE RESTRICT. Update the tests to accept the codes reported by PostgreSQL 17 and 18 while continuing to assert that deletion is refused. Run those tests against both versions; done means all pass on both.

Written by the indexing model from the issue text.

Description

good first issue priority:P2 track:control-plane
Track

C: control plane

Scope
  • PostgreSQL 18 reports 23001 where 17 reports 23503, which fails three tests in fleet-tenant.integration.spec.ts and tenant-schema.integration.spec.ts.
  • Needed before moving the pinned test image past 17.
Acceptance criteria

Those tests pass on both versions, still asserting that the deletion is refused.

Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 17m
Merged PRs (30d)
197

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from shipkeepdev/shipkeep

All issues in shipkeepdev/shipkeep

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.