remove `impl<T: Clone, const N: usize> From<&mut [T]> for SmallVec<T, N> `
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
Research direction
Open conversions.rs and locate the impl From<&mut [T]> for SmallVec<T, N>. Review the surrounding conversions and run the project's tests; done means the redundant implementation is removed with no behavior changes and the tests still pass.
Written by the indexing model from the issue text.
Description
this implementation on conversions.rs is unnecessary since automatic deref coercion on mutable references allows using From::<&[T]>::from(&mut [T]), thus making this implementation redundant
no behavior changes
- Dominant language
- Rust
- Stars
- 1.8k
- Forks
- 229
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 62
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from servo/rust-smallvec
-
add `From<Box<[T]>, A> for SmallVec<T, N, A>` conversionPossibly taken @Ankit-cs claimed this 1 day ago. Opengood first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
servo/rust-smallvec#716 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
correct `From<SmallVec<T, N, A>> for Box<[T]>` implementationPossibly taken @HarshRajSinghania claimed this 4 days ago. Opengood first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
servo/rust-smallvec#714 ·
Maintainers usually reply within 1 day
-
deprecate `from_vec`Possibly taken @bolshoytoster claimed this 3 days ago. Opengood first issue help wanted r-refactor
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
servo/rust-smallvec#712 · 1 comment ·
Maintainers usually reply within 1 day
-
allocator expansion for `From<Vec<T>>` to `From<Vec<T, A>>`Possibly taken @bolshoytoster claimed this 4 days ago. Opengood first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
servo/rust-smallvec#702 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Allocators are stable on nightly RustPossibly taken @GauravPawar101 claimed this 6 days ago. Opengood first issue help wanted r-docs
Difficulty 1/5 Under an hour Newbie friendliness 70/100
servo/rust-smallvec#662 · 3 comments · 3 reactions · 1 assignee ·
Maintainers usually reply within 1 day
All issues in servo/rust-smallvec
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
agentic-os-org/ANOLISA#6742 · 1 comment ·
Maintainers usually reply within 1 day
-
api: storage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
googleapis/google-cloud-rust#7153 ·
Maintainers usually reply within 1 day
-
comp-mysql
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ClickHouse/ClickHouse#124749 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oracle/rust-oracledb#43 · 1 comment ·