deprecate `from_vec`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- backend-api-design
Research direction
Start in conversions.rs and inspect the existing From<Vec<...>> implementation for SmallVec, then compare the deprecation reason on macros.rs. Keep from_vec as a deprecated call through the From implementation, with the deprecation wording matching macros.rs; verify the public API still compiles.
Written by the indexing model from the issue text.
Description
deprecate the from_vec method on SmallVec
the move the source code to the From<Vec<...>> implementation for SmallVec in conversions.rs, and maintain this method as a simple call to that From implementation
that way we are using the idiomatic rust traits instead of having a method for everything
the deprecation reason should mirror that on macros.rs
- Dominant language
- Rust
- Stars
- 1.7k
- Forks
- 225
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 64
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from servo/rust-smallvec
-
good first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
servo/rust-smallvec#716 ·
Maintainers usually reply within 1 day
-
correct `From<SmallVec<T, N, A>> for Box<[T]>` implementationPossibly taken @HarshRajSinghania claimed this 1 day ago. Opengood first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
servo/rust-smallvec#714 ·
Maintainers usually reply within 1 day
-
allocator expansion for `From<Vec<T>>` to `From<Vec<T, A>>`Possibly taken @bolshoytoster claimed this 1 day ago. Opengood first issue help wanted r-feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
servo/rust-smallvec#702 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Allocators are stable on nightly RustPossibly taken @GauravPawar101 claimed this 3 days ago. Opengood first issue help wanted r-docs
Difficulty 1/5 Under an hour Newbie friendliness 70/100
servo/rust-smallvec#662 · 3 comments · 3 reactions · 1 assignee ·
Maintainers usually reply within 1 day
-
good first issue help wanted r-refactor
Difficulty 5/5 Over a week Newbie friendliness 35/100
servo/rust-smallvec#731 · 4 comments ·
Maintainers usually reply within 1 day
All issues in servo/rust-smallvec
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
[Bug]: Bedrock request metadata forwarding does not work for /embeddingsPossibly taken A pull request linked to this issue is open or already merged. Openbug llm translation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
pytest plugin: a crashed xdist worker aborts the whole session with INTERNALERRORPossibly taken @hazelxue claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
skillfs: one malformed chat-log line aborts the entire skill-usage analysis (skill_usage_from_chat_logs.py)Possibly taken @zjncs claimed this today. Opencomponent:skillfs
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
agentic-os-org/ANOLISA#6116 · 1 comment ·
Maintainers usually reply within 1 day