Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

make `reserve` derive from `try_reserve`

Closed
#646 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@bolshoytoster is already working on this.

Since Sep 20, 2026.

Assessment

This issue has not been assessed yet.

Description

good first issue help wanted r-refactor

How come reserve wasn't just

pub fn reserve(&mut self, additional: usize) {
    infallibe(self.try_reserve(additional));
}

?

That's probably out of scope for this PR though.

Same with {,try_}reserve_exact

Originally posted by @bolshoytoster in https://github.com/servo/rust-smallvec/issues/624#issuecomment-5752375705

inherited technical debt @bolshoytoster

Dominant language
Rust
Stars
1.7k
Forks
225
Avg merge
1d 1h
Merged PRs (30d)
63

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from servo/rust-smallvec

All issues in servo/rust-smallvec

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.