api_config::load() doesn't reset address/interface lists before a fallback load
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- networking
Research direction
The bug is in load in src/api_config.cpp, which appends to multicast_addresses_ and multicast_interfaces without clearing them first. Read the fallback loop that calls load for each config source, then reproduce with a config whose multicast.Interfaces has an invalid entry so it fails after partly filling those lists. Done when the fallback (defaults) result contains only its own addresses and interfaces, with no leftovers from the failed attempt.
Written by the indexing model from the issue text.
Description
api_config tries config sources in order and falls back to the next one (finally the built-in defaults) if loading throws. api_config::load (src/api_config.cpp) appends to multicast_addresses_ and multicast_interfaces but never clears them first. If a config file fails after those lists were partly filled (e.g. an invalid entry in multicast.Interfaces), the fallback load appends its values to the leftovers, so the effective configuration mixes both sources.
Fix: clear these lists (and any other accumulated state) at the start of load, or build a fresh object per attempt.
- Dominant language
- C++
- Stars
- 179
- Forks
- 90
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 22
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sccn/liblsl
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 Half a day Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
Similar issues
-
ai_p1 comp-message-queues
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/ClickHouse#125890 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 78/100
yt-project/ewah_bool_utils#215 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
redis/memtier_benchmark#642 ·
Maintainers usually reply within 1 day
-
Feature Request
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
sandboxie-plus/Sandboxie#5653 ·
Maintainers usually reply within 1 day
-
Ctrl-C can abort a node: the state timer asks for the node names after shutdownPossibly taken @fmrico claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fmrico/cascade_lifecycle#24 ·