Test config files contain typos that silently disable them
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
The two bad settings are in testing/lslcfgs/ipv4_lsl100.cfg and ipv6_lsl100.cfg (use_protocol_version under [tuning], which should be UseProtocolVersion) and in testing/lslcfgs/default.cfg (KnownPeers without braces). Read parse_set in src/api_config.cpp to confirm the accepted list syntax and the exact key spelling, then fix the three lines. Done when the protocol-1.00 configs select 1.00, KnownPeers parses to a non-empty list, and the unit tests pass in the cppcmake.yml workflow.
Written by the indexing model from the issue text.
Description
liblsl ignores unknown keys silently, and two of the test configurations in testing/lslcfgs/ don't do what they intend:
ipv4_lsl100.cfgandipv6_lsl100.cfgsetuse_protocol_version=100under[tuning], but the key isUseProtocolVersion(keys are case-sensitive). Tests meant to run with data protocol 1.00 run with 1.10.default.cfgsetsKnownPeers=127.0.0.1without braces.parse_set(src/api_config.cpp) only accepts{...}, so the list is empty. CI copies this file into the working directory before the unit tests (cppcmake.yml).
Fix the two keys. It might also be worth logging a warning for unknown keys and for list values without braces.
- Dominant language
- C++
- Stars
- 179
- Forks
- 90
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 27
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sccn/liblsl
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 Half a day Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FriendsofECCE/ECCE#336 · 1 comment ·
-
Real literal with a 'd' exponent and a kind suffix (1.0d0_4) is accepted; the suffix is ignoredOpenerror not reported low priority semantics
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
bitcoin-core/gui-qml#1030 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day