scripts/standalone_compilation_linux.sh no longer builds
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- build-system
Research direction
The failure is in scripts/standalone_compilation_linux.sh, which compiles a pugixml file that no longer exists and never generates lsl_version.h, which src/common.h includes. Compare the script with the CMake configure_file step that produces lsl_version.h from src/lsl_version.h.in. Before editing, get a maintainer decision on whether to fix or remove the script, since the issue offers both. Done means either a working build on a clean checkout or no remaining references to the script.
Written by the indexing model from the issue text.
Description
scripts/standalone_compilation_linux.sh compiles liblsl without CMake, but on current dev:
- it compiles
thirdparty/pugixml/pugixml.cpp, which no longer exists (pugixml is downloaded by CMake since it moved to FetchContent); src/common.hincludeslsl_version.h, which CMake generates fromsrc/lsl_version.h.in(configure_file); the script doesn't create it.
Either fix the script (download pugixml at a pinned version, generate lsl_version.h with sed), or remove it: CMake ≥ 3.23 is available via pip install cmake on the small ARM boards it was meant for, and building on a Raspberry Pi with CMake works. The README reference was removed in #324.
- Dominant language
- C++
- Stars
- 179
- Forks
- 90
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 27
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sccn/liblsl
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
Similar issues
-
os:Linux
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
acceptable_buffer_backends: unknown backend names are silently ignoredPossibly taken @mini-1235 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ros2/rmw_fastrtps#945 ·
Maintainers usually reply within 1 day
-
bot-triaged module: correctness (silent) module: mps module: NaNs and Infs triage review
Difficulty 2/5 Half a day Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day