core/class/descendants_spec relying on a particular GC behavior
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Read core/class/descendants_spec.rb at the cited line and compare it with core/module/remove_method_spec.rb. Determine whether the specs should depend on GC running between tests, then update the relevant specification once the expected behavior across Ruby implementations is agreed; done means the test no longer relies on an unsuitable GC assumption.
Written by the indexing model from the issue text.
Description
I'm implementing Class#{subclasses,descendants} in Opal. While in MRI GC may run quite consistently for this test to always pass, in Opal we have to rely on JS behavior - and it doesn't help us. A similar situation may happen on other Ruby implementations.
Let's take a look at this:
And then this:
A question would be - do we really want to hardcode a need for GC for this part or an assumption that it will be ran between those 2 tests?
- Dominant language
- Ruby
- Stars
- 623
- Forks
- 403
- Avg merge
- 10h 38m
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby/spec
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Replace most matchers by `obj.should.foo`May be free again @eregon claimed this 194 days ago, and no pull request is open. Open
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
Similar issues
-
🐛 bug 👩💻 équipe CE 🧑🏭 entreprises
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
betagouv/conseillers-entreprises#4808 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
yosiat/panko_serializer#250 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
cline/mcp-marketplace#3886 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100