Delete ament_export_include_directories() and ament_export_libraries() calls
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
The issue lists four specific CMakeLists.txt files in the repository. Open each file, locate the calls to ament_export_include_directories() and ament_export_libraries(), and delete them. Verify the package still builds by running the project's CMake build process. The change is purely mechanical and the exact lines to remove are identified.
Written by the indexing model from the issue text.
Description
We use ament_export_targets() to export modern CMake targets. Downstream packages should use these modern CMake targets instead of old CMake variables. Because the packages below already call ament_export_targets(), we can delete the ament_export_include_directories() and ament_export_libraries() calls.
Modify the following files and delete the ament_export_include_directories() and ament_export_libraries() calls:
rclcpp/CMakeLists.txtrclcpp_action/CMakeLists.txtrclcpp_components/CMakeLists.txtrclcpp_lifecycle/CMakeLists.txt
- Dominant language
- C++
- Stars
- 811
- Forks
- 568
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ros2/rclcpp
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
WaitSet failed remove clears entity ownership and permits the same guard condition in two wait setsOpen
Difficulty 3/5 1-2 days Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
ros2/rclcpp#3289 · 1 comment ·
Maintainers usually reply within 1 day
-
Cannot publish action feedback in CANCELING statePossibly taken @fujitatomoya claimed this 5 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 65/100
ros2/rclcpp#3283 · 8 comments · 2 assignees ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
ros2/rclcpp#3273 · 2 comments ·
Maintainers usually reply within 1 day
Similar issues
-
bug chart-audit
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
HasBacktrace Priority-Critical
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
azerothcore/azerothcore-wotlk#27921 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
yhirose/cpp-peglib#344 ·