Nothing on a signup's page leads to the help page on closing and reopening
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
Research direction
Start with ClosedNotice and Banner in src/components/banner.tsx, then read ClosedNotice.test.tsx and the computer close test in tests/e2e/organizer.spec.ts. Add the help link to the closed notice in the same tab, preserving its current live region and focus behavior. Done means the unit test checks the link and URL, pnpm budgets passes, and the listed lint, typecheck, knip, and test commands pass.
Written by the indexing model from the issue text.
Description
Needs your OK: this adds a link to a help page in the grey Signup closed box, the first link from an organizer screen to a particular help page. Swap pipeline:proposed for pipeline:ready to have it built.
What happens
- There's a help page for this. "Close or reopen a signup" (#650) says what closing does to the people signed up, to reminders and to the link, and how to reopen.
- Nothing on the signup's page links to it.
- Close signup's question (
CloseSignupConfirm) doesn't. On a computer it's in the ⋯ panel, and on a phone in the More actions sheet. - The grey Signup closed box (
ClosedNotice) doesn't either. Since #649 it shows only right after Close signup on that page. - Help in the header goes to the
/helpindex.
- Close signup's question (
- No organizer screen links to a particular help page today. The only links to help are the header's and the footer's.
- The walkthrough noted it. In the UX walkthrough on #610 it was a polish note.
Fix, in outline
- Add a link to
/help/close-or-reopen-a-signupin the grey Signup closed box, after its text: "How closing and reopening work". - Give
Banner(src/components/banner.tsx) an optional link, rather than drawing a second box (CLAUDE.md: reuse banners). It takes only a title and a body today. - Open it in the same tab, so the browser's Back returns to the signup.
Watch for
- Overlap with #587, which also proposes giving
Banneran action slot, for the preview page. Whichever lands second should use the other's slot rather than add a second one. - Budgets.
ClosedNoticeloads on every signup tab, and those budgets were raised by 1 kB in #649.[id]and/editare at 129.1 of 130 kB, so checkpnpm budgets. - The box isn't a live region (
live={false}), and its ✕ gives focus to the title. Keep both. - Tests:
ClosedNotice.test.tsx, and the computer close test intests/e2e/organizer.spec.ts, which checks the box. - Help page: "While it's closed" mentions the grey box. Nothing there needs to change, but run the help-pages skill's
affected-articles.mjson the diff. - CHANGELOG: add a line under Unreleased › Changed.
Choices this makes
- In the box, not in Close's question. The question is a moment to decide, and a link there pulls people away from it. The box shows right after closing, when someone may wonder what happens next.
- Same tab.
- The words "How closing and reopening work".
- Only this help page. Linking other screens to their help pages is a separate decision.
Done when
- Right after Close signup, the grey box shows the link, and it opens
/help/close-or-reopen-a-signupin the same tab. - A unit test in
ClosedNotice.test.tsxchecks the link and its address. pnpm budgetspasses.pnpm lint && pnpm typecheck && pnpm knip && pnpm testpass.
From the UX walkthrough comment on #610 (https://github.com/richshaw/OpenSignup/pull/610#issuecomment-6402399737). Checked against ClosedNotice, CloseSignupConfirm and Banner on main at 1d4ff3a. https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 4
- Avg merge
- 20h 9m
- Merged PRs (30d)
- 156
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from richshaw/OpenSignup
-
enhancement pipeline:proposed pipeline:ux
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
richshaw/OpenSignup#653 ·
Maintainers usually reply within 1 day
-
enhancement pipeline:proposed pipeline:ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
richshaw/OpenSignup#652 ·
Maintainers usually reply within 1 day
-
enhancement good first issue pipeline:ready
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
richshaw/OpenSignup#645 ·
Maintainers usually reply within 1 day
-
bug good first issue pipeline:ready pipeline:ux
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
richshaw/OpenSignup#644 ·
Maintainers usually reply within 1 day
-
bug pipeline:ready pipeline:ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
richshaw/OpenSignup#641 ·
Maintainers usually reply within 1 day
All issues in richshaw/OpenSignup
Similar issues
-
a10y a10y-audit ai-driven-qa claude
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
linagora/twake-directory-manager#219 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
0️⃣ phase/new
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Pulse v7: buildPreferencesFromTelos() bypasses telosSectionOrFile(), renders empty on unified-TELOS installsPossibly taken @zephyr91 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
danielmiessler/LifeOS#2393 ·
Maintainers usually reply within 4 days