Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Nothing on a signup's page leads to the help page on closing and reopening

Aperta Adatta ai principianti
  • Qualcosa non va?
#654 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
accessibility, frontend

Direzione di ricerca

Inizia con ClosedNotice e Banner in src/components/banner.tsx, poi leggi ClosedNotice.test.tsx e il test di chiusura tramite computer in tests/e2e/organizer.spec.ts. Aggiungi il link di assistenza all’avviso di chiusura nella stessa scheda, mantenendo la regione live e il comportamento attuale del focus. Il lavoro è completato quando il test unitario verifica il link e l’URL, pnpm budgets passa e passano i comandi indicati di lint, typecheck, knip e test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement pipeline:proposed pipeline:ux

Needs your OK: this adds a link to a help page in the grey Signup closed box, the first link from an organizer screen to a particular help page. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

  • There's a help page for this. "Close or reopen a signup" (#650) says what closing does to the people signed up, to reminders and to the link, and how to reopen.
  • Nothing on the signup's page links to it.
    • Close signup's question (CloseSignupConfirm) doesn't. On a computer it's in the ⋯ panel, and on a phone in the More actions sheet.
    • The grey Signup closed box (ClosedNotice) doesn't either. Since #649 it shows only right after Close signup on that page.
    • Help in the header goes to the /help index.
  • No organizer screen links to a particular help page today. The only links to help are the header's and the footer's.
  • The walkthrough noted it. In the UX walkthrough on #610 it was a polish note.

Fix, in outline

  • Add a link to /help/close-or-reopen-a-signup in the grey Signup closed box, after its text: "How closing and reopening work".
  • Give Banner (src/components/banner.tsx) an optional link, rather than drawing a second box (CLAUDE.md: reuse banners). It takes only a title and a body today.
  • Open it in the same tab, so the browser's Back returns to the signup.

Watch for

  • Overlap with #587, which also proposes giving Banner an action slot, for the preview page. Whichever lands second should use the other's slot rather than add a second one.
  • Budgets. ClosedNotice loads on every signup tab, and those budgets were raised by 1 kB in #649. [id] and /edit are at 129.1 of 130 kB, so check pnpm budgets.
  • The box isn't a live region (live={false}), and its ✕ gives focus to the title. Keep both.
  • Tests: ClosedNotice.test.tsx, and the computer close test in tests/e2e/organizer.spec.ts, which checks the box.
  • Help page: "While it's closed" mentions the grey box. Nothing there needs to change, but run the help-pages skill's affected-articles.mjs on the diff.
  • CHANGELOG: add a line under Unreleased › Changed.

Choices this makes

  • In the box, not in Close's question. The question is a moment to decide, and a link there pulls people away from it. The box shows right after closing, when someone may wonder what happens next.
  • Same tab.
  • The words "How closing and reopening work".
  • Only this help page. Linking other screens to their help pages is a separate decision.

Done when

  • Right after Close signup, the grey box shows the link, and it opens /help/close-or-reopen-a-signup in the same tab.
  • A unit test in ClosedNotice.test.tsx checks the link and its address.
  • pnpm budgets passes.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass.

From the UX walkthrough comment on #610 (https://github.com/richshaw/OpenSignup/pull/610#issuecomment-6402399737). Checked against ClosedNotice, CloseSignupConfirm and Banner on main at 1d4ff3a. https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K

Lingua principale
TypeScript
Stelle
19
Fork
4
Merge medio
20h 9m
PR unite (30g)
156

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di richshaw/OpenSignup

Tutte le issue di richshaw/OpenSignup

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.