Nothing on a signup's page leads to the help page on closing and reopening
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 72/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- react, typescript
- Área
- accessibility, frontend
Línea de trabajo
Empieza con ClosedNotice y Banner en src/components/banner.tsx; después, lee ClosedNotice.test.tsx y la prueba de cierre por ordenador en tests/e2e/organizer.spec.ts. Añade el enlace de ayuda al aviso de cierre en la misma pestaña y conserva su región live y el comportamiento del foco actuales. La tarea estará terminada cuando la prueba unitaria compruebe el enlace y la URL, pnpm budgets pase y pasen los comandos indicados de lint, typecheck, knip y pruebas.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Needs your OK: this adds a link to a help page in the grey Signup closed box, the first link from an organizer screen to a particular help page. Swap pipeline:proposed for pipeline:ready to have it built.
What happens
- There's a help page for this. "Close or reopen a signup" (#650) says what closing does to the people signed up, to reminders and to the link, and how to reopen.
- Nothing on the signup's page links to it.
- Close signup's question (
CloseSignupConfirm) doesn't. On a computer it's in the ⋯ panel, and on a phone in the More actions sheet. - The grey Signup closed box (
ClosedNotice) doesn't either. Since #649 it shows only right after Close signup on that page. - Help in the header goes to the
/helpindex.
- Close signup's question (
- No organizer screen links to a particular help page today. The only links to help are the header's and the footer's.
- The walkthrough noted it. In the UX walkthrough on #610 it was a polish note.
Fix, in outline
- Add a link to
/help/close-or-reopen-a-signupin the grey Signup closed box, after its text: "How closing and reopening work". - Give
Banner(src/components/banner.tsx) an optional link, rather than drawing a second box (CLAUDE.md: reuse banners). It takes only a title and a body today. - Open it in the same tab, so the browser's Back returns to the signup.
Watch for
- Overlap with #587, which also proposes giving
Banneran action slot, for the preview page. Whichever lands second should use the other's slot rather than add a second one. - Budgets.
ClosedNoticeloads on every signup tab, and those budgets were raised by 1 kB in #649.[id]and/editare at 129.1 of 130 kB, so checkpnpm budgets. - The box isn't a live region (
live={false}), and its ✕ gives focus to the title. Keep both. - Tests:
ClosedNotice.test.tsx, and the computer close test intests/e2e/organizer.spec.ts, which checks the box. - Help page: "While it's closed" mentions the grey box. Nothing there needs to change, but run the help-pages skill's
affected-articles.mjson the diff. - CHANGELOG: add a line under Unreleased › Changed.
Choices this makes
- In the box, not in Close's question. The question is a moment to decide, and a link there pulls people away from it. The box shows right after closing, when someone may wonder what happens next.
- Same tab.
- The words "How closing and reopening work".
- Only this help page. Linking other screens to their help pages is a separate decision.
Done when
- Right after Close signup, the grey box shows the link, and it opens
/help/close-or-reopen-a-signupin the same tab. - A unit test in
ClosedNotice.test.tsxchecks the link and its address. pnpm budgetspasses.pnpm lint && pnpm typecheck && pnpm knip && pnpm testpass.
From the UX walkthrough comment on #610 (https://github.com/richshaw/OpenSignup/pull/610#issuecomment-6402399737). Checked against ClosedNotice, CloseSignupConfirm and Banner on main at 1d4ff3a. https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K
- Lenguaje dominante
- TypeScript
- Estrellas
- 19
- Forks
- 4
- Merge medio
- 20 h 9 min
- PR fusionados (30 d)
- 156
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de richshaw/OpenSignup
-
The help pages never say "pause", so organizers looking for it miss Close or reopen a signupAbiertoenhancement pipeline:proposed pipeline:ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
richshaw/OpenSignup#653 ·
Los mantenedores suelen responder en 1 día
-
enhancement pipeline:proposed pipeline:ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
richshaw/OpenSignup#652 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue pipeline:ready
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
richshaw/OpenSignup#645 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue pipeline:ready pipeline:ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
richshaw/OpenSignup#644 ·
Los mantenedores suelen responder en 1 día
-
bug pipeline:ready pipeline:ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
richshaw/OpenSignup#641 ·
Los mantenedores suelen responder en 1 día
Todos los issues de richshaw/OpenSignup
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
grafana/profiles-drilldown#1212 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
grafana/traces-drilldown#980 ·
Los mantenedores suelen responder en 1 día
-
Manager flashes an empty "errorOccurred" dialog while redirecting a logged-out user to loginAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
openremote/openremote#3487 · 1 comentario ·
-
triage:needs-human
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
garrytan/gbrain#7635 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
coollabsio/jean#867 ·
Los mantenedores suelen responder en 1 día