Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

[Bug] Inconsistencies in the Expected Format Provider in Converters

Closed
  • Is something wrong?
#175 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend, testing

Research direction

Start with SingleToStringTypeConverter.cs, the double and decimal converter files, and the cited DoubleToStringTypeConverterTests.cs cases. Run ReactiveUI.Binding.Tests under fr-FR and compare the converter comments, behavior, and test expectations across cultures. Decide on consistent culture behavior, then align the converters, comments, and tests; done when the suite passes under the affected cultures.

Written by the indexing model from the issue text.

Description

bug
Prerequisites
  • I have searched this repository's open and closed issues for duplicates.
  • I am using the latest stable release.
What happens

There are many inconsistencies regarding the expected format provider in converters.

Concretely, SingleToStringTypeConverter indicates that the conversion is performed "using the invariant culture", but only does that for this one case, while other converters for double, decimal, ..., indicate that the conversion is performed "using the current culture".

To make it even more confusing, there are unit tests to verify both behaviors, which is impossible in many cultures. For example, double to string tests have checks expecting both cultures at the same time (TryConvert_WithConversionHint_FormatsCorrectly, TryConvert_NegativeValue_Succeeds).

What is the expected behavior?

What you expected instead

Converters with consistent behavior, comments, and tests.

Minimal reproduction

N/A

Steps to reproduce
  1. Run ReactiveUI.Binding.Tests using fr-FR culture, for example.
  2. Tests fail, and a deeper search through the code base shows all the inconsistencies mentioned above.
Exception and stack trace
Package and version

Latest main (c79c70ccff42edbd97fe7e1dcac6edabc563dd52)

UI framework

None, this is a class library or console app

Operating system

Windows

Target framework

net10.0

Device and OS version

No response

IDE

No response

Did this work in an earlier version?

No response

Workaround

No response

Additional information

No response

Dominant language
C#
Stars
9
Forks
4
Avg merge
8h 32m
Merged PRs (30d)
60

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactiveui/ReactiveUI.Binding.SourceGenerators

All issues in reactiveui/ReactiveUI.Binding.SourceGenerators

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.