[Bug] Inconsistencies in the Expected Format Provider in Converters
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with SingleToStringTypeConverter.cs, the double and decimal converter files, and the cited DoubleToStringTypeConverterTests.cs cases. Run ReactiveUI.Binding.Tests under fr-FR and compare the converter comments, behavior, and test expectations across cultures. Decide on consistent culture behavior, then align the converters, comments, and tests; done when the suite passes under the affected cultures.
由索引模型根據 Issue 內容生成。
描述
Prerequisites
- I have searched this repository's open and closed issues for duplicates.
- I am using the latest stable release.
What happens
There are many inconsistencies regarding the expected format provider in converters.
Concretely, SingleToStringTypeConverter indicates that the conversion is performed "using the invariant culture", but only does that for this one case, while other converters for double, decimal, ..., indicate that the conversion is performed "using the current culture".
To make it even more confusing, there are unit tests to verify both behaviors, which is impossible in many cultures. For example, double to string tests have checks expecting both cultures at the same time (TryConvert_WithConversionHint_FormatsCorrectly, TryConvert_NegativeValue_Succeeds).
What is the expected behavior?
What you expected instead
Converters with consistent behavior, comments, and tests.
Minimal reproduction
N/A
Steps to reproduce
- Run
ReactiveUI.Binding.Testsusingfr-FRculture, for example. - Tests fail, and a deeper search through the code base shows all the inconsistencies mentioned above.
Exception and stack trace
Package and version
Latest main (c79c70ccff42edbd97fe7e1dcac6edabc563dd52)
UI framework
None, this is a class library or console app
Operating system
Windows
Target framework
net10.0
Device and OS version
No response
IDE
No response
Did this work in an earlier version?
No response
Workaround
No response
Additional information
No response
- 主要語言
- C#
- 星號
- 9
- 分支
- 4
- 平均合併
- 1 天 6 小時
- 30 天內合併 PR
- 6
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
Facepunch/sbox-public#12305 ·
維護者通常 5 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
JiaFeiMiao-K-Cat/DiscImageStudio#205 ·
維護者通常 1 天內回覆
-
bug keep-fresh
難度 2/5 1-3 小時 新手友好度 68/100
Flow-Launcher/Flow.Launcher#4744 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
flyingpie/windows-terminal-quake#419 ·
維護者通常 1 天內回覆
-
enhancement help wanted
難度 2/5 1-3 小時 新手友好度 82/100