[Bug] Inconsistencies in the Expected Format Provider in Converters
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with SingleToStringTypeConverter.cs, the double and decimal converter files, and the cited DoubleToStringTypeConverterTests.cs cases. Run ReactiveUI.Binding.Tests under fr-FR and compare the converter comments, behavior, and test expectations across cultures. Decide on consistent culture behavior, then align the converters, comments, and tests; done when the suite passes under the affected cultures.
由索引模型根据 Issue 内容生成。
描述
Prerequisites
- I have searched this repository's open and closed issues for duplicates.
- I am using the latest stable release.
What happens
There are many inconsistencies regarding the expected format provider in converters.
Concretely, SingleToStringTypeConverter indicates that the conversion is performed "using the invariant culture", but only does that for this one case, while other converters for double, decimal, ..., indicate that the conversion is performed "using the current culture".
To make it even more confusing, there are unit tests to verify both behaviors, which is impossible in many cultures. For example, double to string tests have checks expecting both cultures at the same time (TryConvert_WithConversionHint_FormatsCorrectly, TryConvert_NegativeValue_Succeeds).
What is the expected behavior?
What you expected instead
Converters with consistent behavior, comments, and tests.
Minimal reproduction
N/A
Steps to reproduce
- Run
ReactiveUI.Binding.Testsusingfr-FRculture, for example. - Tests fail, and a deeper search through the code base shows all the inconsistencies mentioned above.
Exception and stack trace
Package and version
Latest main (c79c70ccff42edbd97fe7e1dcac6edabc563dd52)
UI framework
None, this is a class library or console app
Operating system
Windows
Target framework
net10.0
Device and OS version
No response
IDE
No response
Did this work in an earlier version?
No response
Workaround
No response
Additional information
No response
- 主要语言
- C#
- 星标
- 9
- 派生
- 2
- 平均合并
- 7 小时 7 分钟
- 30 天内合并 PR
- 75
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
reactiveui/ReactiveUI.Binding.SourceGenerators 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 30/100
reactiveui/ReactiveUI.Binding.SourceGenerators#3 ·
维护者通常 1 天内回复
查看 reactiveui/ReactiveUI.Binding.SourceGenerators 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
area:re1 bounty help wanted needs-game
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 68/100
StackExchange/StackExchange.Redis#3274 ·
维护者通常 1 天内回复
-
affected/v17 affected/v18 area/frontend type/bug
难度 2/5 1-3 小时 新手友好度 82/100
umbraco/Umbraco-CMS#24186 ·
维护者通常 2 天内回复