Abstract pexpect.SpawnBase has no send/sendline/write/writelines stubs

Open Beginner friendly
#11,914 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Locate the SpawnBase stub in typeshed and compare it with the child stubs that define send, sendline, write, and writelines. Check the relevant typing tests or run the repository's type-checking tests to confirm that SpawnBase annotations expose these methods without breaking existing implementations.

Written by the indexing model from the issue text.

Description

The actual implementation of pexpect.SpawnBase does not contain these functions but it is an abstract class and all children have these write methods.

Since almost all interesting pexpect code does some form of writing it is impractical to use SpawnBase as an annotation. The only viable solution seem to be annotating with PopenSpawn or maybe an union if you actually want to be generic?

Perhaps it would be acceptable to add these stubs to SpawnBase despite what is written in the implementation.

Dominant language
Python
Stars
5.1k
Forks
2.1k
Avg merge
1d 13h
Merged PRs (30d)
73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/typeshed

All issues in python/typeshed

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.