Don't run pyright basic checks on projects with strict pyright settings in CI

Open Beginner friendly
#16,005 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
github-actions, python
Domain
ci-cd

Research direction

Start with .github/workflows/tests.yml at lines 126-140 and review the recent CI runs referenced in issue #16004. Trace how projects with strict pyright settings are selected for basic checks. Done means strict projects no longer produce unnecessary pyright-ignore errors during the basic run while the intended CI checks remain covered.

Written by the indexing model from the issue text.

Description

project: infrastructure

Relevant CI configuration: https://github.com/python/typeshed/blob/67895308f89221c97c67c13845b96d65d725750c/.github/workflows/tests.yml#L126-L140

This could lead to a deadlock situation with Schrodinger's pyright: ignore comments that are only relevant to the strict run but throw error: Unnecessary "# pyright: ignore" in the basic checks run. See recent CI runs in #16004 for an example.

Dominant language
Python
Stars
5.1k
Forks
2.1k
Avg merge
1d 13h
Merged PRs (30d)
73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/typeshed

All issues in python/typeshed

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.