Authlib integration requests_client OAuth2Session missing inheritance

Open Beginner friendly
#15,548 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
python

Research direction

Open stubs/Authlib/authlib/integrations/requests_client/oauth2_session.pyi at line 20 and compare it with Authlib's oauth2_session.py at line 46. Confirm the declared OAuth2Session base and import match the implementation, then run the applicable typeshed validation; done means the stub exposes the requests.Session inheritance.

Written by the indexing model from the issue text.

Description

stubs: improvement

https://github.com/python/typeshed/blob/main/stubs/Authlib/authlib/integrations/requests_client/oauth2_session.pyi#L20

There is a comment here saying OAuth2Session inherits from requests.Session which is correct according to:

https://github.com/authlib/authlib/blob/main/authlib/integrations/requests_client/oauth2_session.py#L46

I think the fix is to from requests import Session at the top of the file and add Session to the class definition?

If that is correct I could open a PR.

Dominant language
Python
Stars
5.1k
Forks
2.1k
Avg merge
1d 13h
Merged PRs (30d)
73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/typeshed

All issues in python/typeshed

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.