[rasterio] `transform.rowcol` return typing possibly incorrect?

Open Beginner friendly
#16,342 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
tooling

Research direction

Start by reading rasterio/transform.py around line 295 and compare the rowcol docstring with its runtime behavior. Then locate the corresponding typeshed stub and its tests, verify whether float results are possible, and update the declared return type if needed so the stub matches the implementation.

Written by the indexing model from the issue text.

Description

From what we expect and what the docstring of this method says in rasterio, I believe the return typing isn't strictly int it can be floats? Please could someone double check to verify?

https://github.com/rasterio/rasterio/blob/main/rasterio/transform.py#L295

Dominant language
Python
Stars
5.1k
Forks
2.1k
Avg merge
1d 13h
Merged PRs (30d)
73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/typeshed

All issues in python/typeshed

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.