Possibility of beam irradiance from behind plane of array
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #2913 by @Noumenon-ai — closed without merging
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with poa_components() and inspect beam_component() for the same clipping order. Locate the existing irradiance-component tests and add coverage for negative DNI when aoi >= 90; done means both paths return zero beam irradiance while existing positive-angle behavior remains intact.
Written by the indexing model from the issue text.
Description
Describe the bug
The function poa_components() contains the following line:
poa_direct = np.maximum(dni * np.cos(np.radians(aoi)), 0)
This usually works, but is not correct because it is the cosine that should be clipped, not the product. When using raw DNI measurements negative values are sometimes present, and these could produce a very small positive poa_direct when the sun is behind the plane of array.
Expected behavior
poa_direct is always zero when aoi >= 90.
Possible solution:
poa_direct = dni * np.maximum(np.cos(np.radians(aoi)), 0)
Additional context
The function beam_component() appears to have the same problem.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 1.2k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pvlib/pvlib-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pvlib/pvlib-python#2939 ·
Maintainers usually reply within 1 day
-
detect_clearsky and prilliman fail on DST days, kimber fails on tz-naive data (since #2924)Possibly taken @pranaysb claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pvlib/pvlib-python#2935 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 72/100
pvlib/pvlib-python#2921 · 4 comments · 3 reactions ·
Maintainers usually reply within 1 day
-
use offset parameter instead of calculating bday in cdromPossibly taken @chenyi6758-source claimed this 20 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
pvlib/pvlib-python#2902 ·
Maintainers usually reply within 1 day
-
Add an example or documentation on using 'bhi' from ERA5May be free again @anshurajbisoyi98-ctrl claimed this 35 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
pvlib/pvlib-python#2880 · 2 comments ·
Maintainers usually reply within 1 day
All issues in pvlib/pvlib-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
adafruit/Fruit-Jam-OS#98 ·
-
python triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
microsoft/semantic-kernel#14753 ·
Maintainers usually reply within 5 days
-
area:cli area:configuration documentation priority:low size:small
Difficulty 1/5 1-3 hours Newbie friendliness 80/100
RonaldHensbergen/composable-data-stack#1222 ·
Maintainers usually reply within 1 day
-
bug python
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
area: i18n bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days