Puppeteer `BrowserOptions` overlaps with Lighthouse `Config`

Open
  • Is something wrong?
#231 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
cli

Research direction

Read the Lighthouse Config and Puppeteer BrowserOptions examples in the issue, then review related issue #142 for context. Determine how the two settings should coordinate browser window and viewport sizes; done means the project has a clear way to configure both without conflicting values.

Written by the indexing model from the issue text.

Description

bug

To handle different device sizes we have different places to configure them:

  • Lighthouse Config
  • Puppeteer Browser

Lighthouse Config

const lighthouseConfig: Config = {
  extends: 'lighthouse:default',
  settings: {
    formFactor: 'desktop',      
    screenEmulation: {
      mobile: false,
      width: 1350,
      height: 940,
      deviceScaleFactor: 1,
      disabled: false
    }
  }
}

This setting applies to the browsers window not the viewport.

Puppeteer BrowserOptions

// 
const browserOptions: BrowserOptions = {
  defaultViewport: { 
  isMobile: false, 
  isLandscape: false, 
   width: 1350,
   height: 940,
  }
}

This setting applies to the Browsers viewport, not window.

BrowserOptions-vs-LhConfig

This issue is slightly connected with #142

Dominant language
HTML
Stars
131
Forks
7
Avg merge
7h 58m
Merged PRs (30d)
42

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from push-based/user-flow

All issues in push-based/user-flow

Similar issues

More CLI issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.