Does Array.index need to be a foreign import?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- backend
Research direction
The issue names Array.index, length, and unsafeIndexImpl, and mentions the backend optimizer. Start by reading the implementation of Array.index and how its foreign import is used, then check whether the optimizer change described in the issue has landed. Done means determining whether the bounds check can be implemented in PureScript while preserving the expected behavior and enabling the stated optimization.
Written by the indexing model from the issue text.
Description
The logic of Array.index can be implemented in terms of length and unsafeIndexImpl. Is it necessary for it to be foreign? In backend-optimizer, I'm preparing a change to inline the bounds check so that the Just allocation can be eliminated in some cases. If index bounds checking was implemented in PureScript rather than FFI, this would just work.
- Dominant language
- PureScript
- Stars
- 58
- Forks
- 70
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from purescript/purescript-arrays
-
Difficulty 1/5 Under an hour Newbie friendliness 55/100
purescript/purescript-arrays#246 ·
-
generate functionOpen
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
purescript/purescript-arrays#244 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
purescript/purescript-arrays#242 · 2 comments ·
-
`groupBy` has unexpected `l` argument for `a -> a -> Boolean` predicateMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
purescript/purescript-arrays#229 · 3 comments ·
-
type: enhancement
Difficulty 4/5 3-5 days Newbie friendliness 30/100
purescript/purescript-arrays#215 · 3 comments ·
All issues in purescript/purescript-arrays
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
milind-soni/OpenMausBot#5829 ·
Maintainers usually reply within 1 day