bug: pnpm cache hits provide little install speedup because lockfile verification is not cached
Mantenedores costumam responder em até 7 dias
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 52/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- github-actions, node.js, typescript
Direção de pesquisa
Read the pnpm cache handling in actions/setup-node and trace how it resolves, restores, and saves the package store cache. Check the existing tests for pnpm caching, then identify how a separate key can use the OS, architecture, and lockfile hash while keeping failures non-fatal. Done when the verification log is independently restored and saved, including on a store cache hit, with npm and Yarn behavior unchanged.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Description
With pnpm 11+, actions/setup-node's cache: pnpm can provide little or no installation speedup, even when the cache is successfully restored.
The reason is that setup-node caches only pnpm's package store, while pnpm stores lockfile verification results separately in <cacheDir>/lockfile-verified.jsonl.
These results allow pnpm to avoid repeating registry-backed verification of lockfile entries, including integrity checks and applicable supply-chain policies such as minimumReleaseAge and trustPolicy.
Because the verification log is not included in the cache, every CI job repeats the verification, even when the package store is fully cached and the lockfile is unchanged.
In workloads where verification dominates installation time, the store cache becomes largely ineffective.
Action version
actions/[email protected]
Platform
- Ubuntu
- macOS
- Windows
Runner type
- Hosted
- Self-hosted
Tools version
- pnpm: 12.16.1
- Node.js: Not recorded
- Lockfile: Approximately 2,000 entries (868 KB)
- Configuration:
minimumReleaseAge: 1440trustPolicy: no-downgrade
Repro steps
- Configure
actions/setup-nodewithcache: pnpmin a repository using pnpm 12 and the supply-chain policies above. - Run
pnpm install --frozen-lockfile. - Run the workflow again without changing the lockfile.
- Confirm that the package store cache is restored successfully.
- Compare installation times with and without the cache, and with the lockfile verification log restored separately.
Measurements
| Scenario | Result |
|---|---|
| GitHub Actions, warm store (27 install jobs) | 13–22s/job, 392s total |
| Cold install without any cache | 13–14s |
| Controlled test: warm store, verification log missing | 26s |
| Controlled test: warm store, verification log restored | 20s |
| Parallel CI fleet (25 jobs), before → after | Median 32s → 18s; aggregate 818s → 455s |
Despite a successful store cache hit, installation time was comparable to a completely uncached installation.
Restoring the verification log reduced dependency setup time by approximately 6 seconds per job in the controlled experiment.
The fleet-level improvement was larger, although it also included other configuration changes.
Similar results were reported in pnpm/setup#30: lockfile verification accounted for 16.6 of 17.6 seconds on Linux and 40.1 of 42.4 seconds on Windows.
Expected behavior
When the lockfile is unchanged and previously computed verification results remain valid, cache: pnpm should reuse those results along with the package store.
A successful cache hit should avoid redundant verification work, allowing subsequent installations to benefit from caching.
Actual behavior
setup-node restores only the package store.
The lockfile verification log is never restored, so pnpm repeats registry-backed verification on every job.
As a result, cache: pnpm provides almost no performance benefit in workloads dominated by lockfile verification, despite reporting successful cache hits.
Suggested solution
Cache <cacheDir>/lockfile-verified.jsonl independently of the package store.
- Resolve the cache directory using
pnpm cache path, available in pnpm 12. If unavailable, retain the existing behavior. - Use a separate cache key, incorporating the OS, architecture, and lockfile hash, without prefix-based fallback.
- Restore the verification log independently of whether the package store cache hits or misses.
- Save the verification log even when the package store cache hits. The current implementation skips saving on an exact store cache hit. Simply adding this file to the existing store cache paths would not populate verification logs for existing cache entries.
- Keep failures non-fatal. A missing or unusable verification cache should cause pnpm to perform its normal verification.
- Leave npm and Yarn unchanged.
Only the verification log should be cached, rather than the entire pnpm cache directory.
Security considerations
Restoring the verification log does not bypass pnpm's supply-chain protections.
pnpm itself determines whether previously recorded verification results can be trusted for the current lockfile and policy configuration. Unusable results trigger normal verification.
This approach is already implemented by pnpm/setup.
References
- Linguagem predominante
- TypeScript
- Estrelas
- 5k
- Forks
- 1.7k
- Merge médio
- 5d 1h
- PRs com merge (30d)
- 1
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Sem guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de actions/setup-node
-
`mirror-token` is sent to GitHub instead of `token` when `mirror` is setTalvez já em andamento @v-gowridurgad assumiu há 10 dias. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
actions/setup-node#1662 · 1 comentário · 1 responsável ·
Mantenedores costumam responder em até 7 dias
-
feature request
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
actions/setup-node#1531 · 1 comentário · 4 reações ·
Mantenedores costumam responder em até 7 dias
-
enhancement
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 58/100
actions/setup-node#1670 · 1 comentário ·
Mantenedores costumam responder em até 7 dias
-
Provide `allow-prereleases` (or similar) option for Node.js 27 AlphaTalvez já em andamento @v-priyagupta108 assumiu há 7 dias. Abertafeature request
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 62/100
actions/setup-node#1657 · 5 comentários · 4 reações · 1 responsável ·
Mantenedores costumam responder em até 7 dias
-
Improved error message when a required os lib is missingTalvez já em andamento @OKAN-SOFTWARE assumiu há 20 dias. Abertafeature request
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 55/100
actions/setup-node#1651 · 1 comentário ·
Mantenedores costumam responder em até 7 dias
Todas as issues de actions/setup-node
Issues semelhantes
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysTalvez já em andamento @pcbeingused333 assumiu hoje. AbertaBug db: d1-sqlite Payload OSS
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
payloadcms/payload#19766 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
device-management-toolkit/sample-web-ui#3711 ·
Mantenedores costumam responder em até 1 dia
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
elastic/kibana#306401 · 3 comentários ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
agentes-chat/agentes-chat#927 ·
Mantenedores costumam responder em até 1 dia
-
Closing a pinned tab jumps to the Tabs section instead of the next open pinned tabTalvez já em andamento @seenimohamed assumiu hoje. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
ardia-browser/ardia#2769 ·
Mantenedores costumam responder em até 1 dia