Resolve mise aliases such as `lts` when reading mise.toml

Aberta
#1,670 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 7 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
58/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
github-actions, node.js, typescript
Domínio
ci-cd, devops, tooling

Direção de pesquisa

Start by tracing how mise.toml values flow from getNodeVersionFromFile into isLtsAlias and version resolution. Check the existing tests for mise version files and LTS aliases, then add coverage for node = "lts"; done means it resolves as the current LTS or returns a clear error for unsupported mise aliases.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement

Description:

node-version-file: mise.toml (added in v7.1.0, #1421) reads [tools] node and passes the value through unchanged. Values that are valid for mise but are not in setup-node's version syntax then fail to resolve.

The common case is LTS:

# mise.toml
[tools]
node = "lts"
- uses: actions/[email protected]
  with:
    node-version-file: mise.toml

getNodeVersionFromFile returns lts. isLtsAlias only matches values that start with lts/, so lts is treated as a semver range, matches no release, and the step fails.

Proposal: when the version comes from mise.toml, translate mise's aliases to setup-node's syntax before resolving. At minimum, map lts to lts/*. Other mise-specific aliases could be handled the same way, or rejected with a clear error that names the unsupported value.

Justification:

A mise.toml is written for mise, and node = "lts" is the usual way to ask mise for the current LTS. Users who adopt the new mise.toml support expect the file they already have to work. Today the only option is to rewrite it as lts/*, which makes the file depend on setup-node's syntax instead of mise's, or to keep a separate node-version input in the workflow, which defeats the point of reading the file.

Are you willing to submit a PR?

Not at this time.

Linguagem predominante
TypeScript
Estrelas
5k
Forks
1.7k
Merge médio
5d 1h
PRs com merge (30d)
1

Preparar o ambiente

  • Sem Dockerfile nem arquivo Docker Compose
  • Tem um modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de actions/setup-node

Todas as issues de actions/setup-node

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.