bug: pnpm cache hits provide little install speedup because lockfile verification is not cached

オープン
#1,672 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 7 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
52/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
github-actions, node.js, typescript
領域
ci-cd, devops

調査の方向性

Read the pnpm cache handling in actions/setup-node and trace how it resolves, restores, and saves the package store cache. Check the existing tests for pnpm caching, then identify how a separate key can use the OS, architecture, and lockfile hash while keeping failures non-fatal. Done when the verification log is independently restored and saved, including on a store cache hit, with npm and Yarn behavior unchanged.

索引モデルが issue の本文から書いたものです。

説明

bug needs triage

Description

With pnpm 11+, actions/setup-node's cache: pnpm can provide little or no installation speedup, even when the cache is successfully restored.

The reason is that setup-node caches only pnpm's package store, while pnpm stores lockfile verification results separately in <cacheDir>/lockfile-verified.jsonl.

These results allow pnpm to avoid repeating registry-backed verification of lockfile entries, including integrity checks and applicable supply-chain policies such as minimumReleaseAge and trustPolicy.

Because the verification log is not included in the cache, every CI job repeats the verification, even when the package store is fully cached and the lockfile is unchanged.

In workloads where verification dominates installation time, the store cache becomes largely ineffective.

Action version

actions/[email protected]

Platform

  • Ubuntu
  • macOS
  • Windows

Runner type

  • Hosted
  • Self-hosted

Tools version

  • pnpm: 12.16.1
  • Node.js: Not recorded
  • Lockfile: Approximately 2,000 entries (868 KB)
  • Configuration:
    • minimumReleaseAge: 1440
    • trustPolicy: no-downgrade

Repro steps

  1. Configure actions/setup-node with cache: pnpm in a repository using pnpm 12 and the supply-chain policies above.
  2. Run pnpm install --frozen-lockfile.
  3. Run the workflow again without changing the lockfile.
  4. Confirm that the package store cache is restored successfully.
  5. Compare installation times with and without the cache, and with the lockfile verification log restored separately.
Measurements
Scenario Result
GitHub Actions, warm store (27 install jobs) 13–22s/job, 392s total
Cold install without any cache 13–14s
Controlled test: warm store, verification log missing 26s
Controlled test: warm store, verification log restored 20s
Parallel CI fleet (25 jobs), before → after Median 32s → 18s; aggregate 818s → 455s

Despite a successful store cache hit, installation time was comparable to a completely uncached installation.

Restoring the verification log reduced dependency setup time by approximately 6 seconds per job in the controlled experiment.

The fleet-level improvement was larger, although it also included other configuration changes.

Similar results were reported in pnpm/setup#30: lockfile verification accounted for 16.6 of 17.6 seconds on Linux and 40.1 of 42.4 seconds on Windows.

Expected behavior

When the lockfile is unchanged and previously computed verification results remain valid, cache: pnpm should reuse those results along with the package store.

A successful cache hit should avoid redundant verification work, allowing subsequent installations to benefit from caching.

Actual behavior

setup-node restores only the package store.

The lockfile verification log is never restored, so pnpm repeats registry-backed verification on every job.

As a result, cache: pnpm provides almost no performance benefit in workloads dominated by lockfile verification, despite reporting successful cache hits.

Suggested solution

Cache <cacheDir>/lockfile-verified.jsonl independently of the package store.

  1. Resolve the cache directory using pnpm cache path, available in pnpm 12. If unavailable, retain the existing behavior.
  2. Use a separate cache key, incorporating the OS, architecture, and lockfile hash, without prefix-based fallback.
  3. Restore the verification log independently of whether the package store cache hits or misses.
  4. Save the verification log even when the package store cache hits. The current implementation skips saving on an exact store cache hit. Simply adding this file to the existing store cache paths would not populate verification logs for existing cache entries.
  5. Keep failures non-fatal. A missing or unusable verification cache should cause pnpm to perform its normal verification.
  6. Leave npm and Yarn unchanged.

Only the verification log should be cached, rather than the entire pnpm cache directory.

Security considerations

Restoring the verification log does not bypass pnpm's supply-chain protections.

pnpm itself determines whether previously recorded verification results can be trusted for the current lockfile and policy configuration. Unusable results trigger normal verification.

This approach is already implemented by pnpm/setup.

References

主要言語
TypeScript
スター
5k
フォーク
1.7k
平均マージ
5日 1時間
マージ済み PR(30日)
1

環境構築

  • Dockerfile・Docker Compose ファイルなし
  • プルリクエストのテンプレートあり
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

actions/setup-node のほかの issue

actions/setup-node の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。