bug: pnpm cache hits provide little install speedup because lockfile verification is not cached
メンテナーはふだん 7 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 52/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- github-actions, node.js, typescript
調査の方向性
Read the pnpm cache handling in actions/setup-node and trace how it resolves, restores, and saves the package store cache. Check the existing tests for pnpm caching, then identify how a separate key can use the OS, architecture, and lockfile hash while keeping failures non-fatal. Done when the verification log is independently restored and saved, including on a store cache hit, with npm and Yarn behavior unchanged.
索引モデルが issue の本文から書いたものです。
説明
Description
With pnpm 11+, actions/setup-node's cache: pnpm can provide little or no installation speedup, even when the cache is successfully restored.
The reason is that setup-node caches only pnpm's package store, while pnpm stores lockfile verification results separately in <cacheDir>/lockfile-verified.jsonl.
These results allow pnpm to avoid repeating registry-backed verification of lockfile entries, including integrity checks and applicable supply-chain policies such as minimumReleaseAge and trustPolicy.
Because the verification log is not included in the cache, every CI job repeats the verification, even when the package store is fully cached and the lockfile is unchanged.
In workloads where verification dominates installation time, the store cache becomes largely ineffective.
Action version
actions/[email protected]
Platform
- Ubuntu
- macOS
- Windows
Runner type
- Hosted
- Self-hosted
Tools version
- pnpm: 12.16.1
- Node.js: Not recorded
- Lockfile: Approximately 2,000 entries (868 KB)
- Configuration:
minimumReleaseAge: 1440trustPolicy: no-downgrade
Repro steps
- Configure
actions/setup-nodewithcache: pnpmin a repository using pnpm 12 and the supply-chain policies above. - Run
pnpm install --frozen-lockfile. - Run the workflow again without changing the lockfile.
- Confirm that the package store cache is restored successfully.
- Compare installation times with and without the cache, and with the lockfile verification log restored separately.
Measurements
| Scenario | Result |
|---|---|
| GitHub Actions, warm store (27 install jobs) | 13–22s/job, 392s total |
| Cold install without any cache | 13–14s |
| Controlled test: warm store, verification log missing | 26s |
| Controlled test: warm store, verification log restored | 20s |
| Parallel CI fleet (25 jobs), before → after | Median 32s → 18s; aggregate 818s → 455s |
Despite a successful store cache hit, installation time was comparable to a completely uncached installation.
Restoring the verification log reduced dependency setup time by approximately 6 seconds per job in the controlled experiment.
The fleet-level improvement was larger, although it also included other configuration changes.
Similar results were reported in pnpm/setup#30: lockfile verification accounted for 16.6 of 17.6 seconds on Linux and 40.1 of 42.4 seconds on Windows.
Expected behavior
When the lockfile is unchanged and previously computed verification results remain valid, cache: pnpm should reuse those results along with the package store.
A successful cache hit should avoid redundant verification work, allowing subsequent installations to benefit from caching.
Actual behavior
setup-node restores only the package store.
The lockfile verification log is never restored, so pnpm repeats registry-backed verification on every job.
As a result, cache: pnpm provides almost no performance benefit in workloads dominated by lockfile verification, despite reporting successful cache hits.
Suggested solution
Cache <cacheDir>/lockfile-verified.jsonl independently of the package store.
- Resolve the cache directory using
pnpm cache path, available in pnpm 12. If unavailable, retain the existing behavior. - Use a separate cache key, incorporating the OS, architecture, and lockfile hash, without prefix-based fallback.
- Restore the verification log independently of whether the package store cache hits or misses.
- Save the verification log even when the package store cache hits. The current implementation skips saving on an exact store cache hit. Simply adding this file to the existing store cache paths would not populate verification logs for existing cache entries.
- Keep failures non-fatal. A missing or unusable verification cache should cause pnpm to perform its normal verification.
- Leave npm and Yarn unchanged.
Only the verification log should be cached, rather than the entire pnpm cache directory.
Security considerations
Restoring the verification log does not bypass pnpm's supply-chain protections.
pnpm itself determines whether previously recorded verification results can be trusted for the current lockfile and policy configuration. Unusable results trigger normal verification.
This approach is already implemented by pnpm/setup.
References
- 主要言語
- TypeScript
- スター
- 5k
- フォーク
- 1.7k
- 平均マージ
- 5日 1時間
- マージ済み PR(30日)
- 1
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドなし
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
actions/setup-node のほかの issue
-
`mirror-token` is sent to GitHub instead of `token` when `mirror` is set対応中かも @v-gowridurgad が 10 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
actions/setup-node#1662 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 7 日以内に返信
-
feature request
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
actions/setup-node#1531 · コメント 1 件 · リアクション 4 件 ·
メンテナーはふだん 7 日以内に返信
-
enhancement
難易度 3/5 1〜2日 初心者へのやさしさ 58/100
actions/setup-node#1670 · コメント 1 件 ·
メンテナーはふだん 7 日以内に返信
-
Provide `allow-prereleases` (or similar) option for Node.js 27 Alpha対応中かも @v-priyagupta108 が 7 日前に担当しました。 オープンfeature request
難易度 3/5 1〜2日 初心者へのやさしさ 62/100
actions/setup-node#1657 · コメント 5 件 · リアクション 4 件 · 担当者 1 名 ·
メンテナーはふだん 7 日以内に返信
-
Improved error message when a required os lib is missing対応中かも @OKAN-SOFTWARE が 20 日前に担当しました。 オープンfeature request
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
actions/setup-node#1651 · コメント 1 件 ·
メンテナーはふだん 7 日以内に返信
actions/setup-node の issue をすべて見る
似ている issue
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keys対応中かも @pcbeingused333 が今日担当しました。 オープンBug db: d1-sqlite Payload OSS
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
payloadcms/payload#19766 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
device-management-toolkit/sample-web-ui#3711 ·
メンテナーはふだん 1 日以内に返信
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
elastic/kibana#306401 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
agentes-chat/agentes-chat#927 ·
メンテナーはふだん 1 日以内に返信
-
Closing a pinned tab jumps to the Tabs section instead of the next open pinned tab対応中かも @seenimohamed が今日担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
ardia-browser/ardia#2769 ·
メンテナーはふだん 1 日以内に返信