Resolve mise aliases such as `lts` when reading mise.toml

未關閉
#1,670 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 7 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
58/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
github-actions, node.js, typescript
領域
ci-cd, devops, tooling

研究方向

Start by tracing how mise.toml values flow from getNodeVersionFromFile into isLtsAlias and version resolution. Check the existing tests for mise version files and LTS aliases, then add coverage for node = "lts"; done means it resolves as the current LTS or returns a clear error for unsupported mise aliases.

由索引模型根據 Issue 內容生成。

描述

enhancement

Description:

node-version-file: mise.toml (added in v7.1.0, #1421) reads [tools] node and passes the value through unchanged. Values that are valid for mise but are not in setup-node's version syntax then fail to resolve.

The common case is LTS:

# mise.toml
[tools]
node = "lts"
- uses: actions/[email protected]
  with:
    node-version-file: mise.toml

getNodeVersionFromFile returns lts. isLtsAlias only matches values that start with lts/, so lts is treated as a semver range, matches no release, and the step fails.

Proposal: when the version comes from mise.toml, translate mise's aliases to setup-node's syntax before resolving. At minimum, map lts to lts/*. Other mise-specific aliases could be handled the same way, or rejected with a clear error that names the unsupported value.

Justification:

A mise.toml is written for mise, and node = "lts" is the usual way to ask mise for the current LTS. Users who adopt the new mise.toml support expect the file they already have to work. Today the only option is to rewrite it as lts/*, which makes the file depend on setup-node's syntax instead of mise's, or to keep a separate node-version input in the workflow, which defeats the point of reading the file.

Are you willing to submit a PR?

Not at this time.

主要語言
TypeScript
星號
5k
分支
1.7k
平均合併
5 天 1 小時
30 天內合併 PR
1

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

actions/setup-node 的其他 Issue

查看 actions/setup-node 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。