Make reference auditors honor `audit_scoring_policy` in the manifest

Aberta
  • Algo errado?
#330 4 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@0xzoz já está trabalhando nisso.

Desde 12/11/2026.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
54/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
python, solidity
Domínio
machine-learning, testing

Direção de pesquisa

Read both reference implementations of load_scoring_policy, including cache_model_1/services/scoring.py, and compare them with the GI-start consumer at dincli/cli/modelownerd/gi.py and the shipped manifest. Trace both auditors' service tests and run focused cases with two different min_accuracy thresholds. Done means both auditors honor the documented canonical field, edge cases for missing, legacy, conflicting, and malformed policies are covered, and the example manifests and documentation explain the median rule.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Approved

Observed against ed175d0deceddfa2e63175ec7752c800b31c1fbf during the November 10 Fashion-MNIST local test investigation. The subsequent full round with three notebooks and a Raspberry Pi used recorded workarounds; its success does not establish that this upstream defect is fixed. Related: #276 and #39.

Problem and evidence

The shipped manifests put thresholds under audit_scoring_policy, and GI-start code reads that field. Both reference load_scoring_policy implementations read scoring_policy. With the shipped layout they silently use defaults instead of the configured audit thresholds.

A focused reproduction extracted the actual upstream loader and default dictionary, wrote the shipped manifest with min_accuracy changed to 99, and called the loader. Both models returned an effective threshold of 50.0. This is a loader-level reproduction, not a second live rejection/acceptance experiment.

The numeric defaults matched our intended gates during the completed round, so this does not show that a model was wrongly accepted in that run. It shows that a model owner's non-default policy can be ignored.

Proposed scope

Choose and document one canonical field across manifests and consumers. If supporting the old name, define explicit precedence or reject conflicting values. Validate policy shape and test non-default values through the auditor service. Align the stale legacy_mean_until_contract_v2 metadata with the median already used on-chain; do not change the contract aggregation rule as part of this fix.

Acceptance criteria
  • Changing audit_scoring_policy.metrics.thresholds.min_accuracy changes the policy used by both reference auditors.
  • A known model passes/fails as expected under two deliberately different thresholds.
  • Missing fields, legacy aliases, conflicting fields and malformed policies have documented behavior.
  • GI pass-score configuration and auditor eligibility policy remain distinct, intentional controls.
  • Example manifests and documentation describe the effective median rule.
Full-round test report

See Discussion #331 — Fashion-MNIST with three notebooks and a Raspberry Pi for the setup diagram, completed protocol roles, results and experiment adaptations.

Linguagem predominante
Python
Estrelas
4
Forks
7
Merge médio
5d 15h
PRs com merge (30d)
43

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de InfiniteZeroFoundation/DevNet

Todas as issues de InfiniteZeroFoundation/DevNet

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.