Make reference auditors honor `audit_scoring_policy` in the manifest

Offen
  • Stimmt etwas nicht?
#330 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@0xzoz arbeitet bereits daran.

Seit 12.11.2026.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
54/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python, solidity
Bereich
machine-learning, testing

Rechercherichtung

Read both reference implementations of load_scoring_policy, including cache_model_1/services/scoring.py, and compare them with the GI-start consumer at dincli/cli/modelownerd/gi.py and the shipped manifest. Trace both auditors' service tests and run focused cases with two different min_accuracy thresholds. Done means both auditors honor the documented canonical field, edge cases for missing, legacy, conflicting, and malformed policies are covered, and the example manifests and documentation explain the median rule.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Approved

Observed against ed175d0deceddfa2e63175ec7752c800b31c1fbf during the November 10 Fashion-MNIST local test investigation. The subsequent full round with three notebooks and a Raspberry Pi used recorded workarounds; its success does not establish that this upstream defect is fixed. Related: #276 and #39.

Problem and evidence

The shipped manifests put thresholds under audit_scoring_policy, and GI-start code reads that field. Both reference load_scoring_policy implementations read scoring_policy. With the shipped layout they silently use defaults instead of the configured audit thresholds.

A focused reproduction extracted the actual upstream loader and default dictionary, wrote the shipped manifest with min_accuracy changed to 99, and called the loader. Both models returned an effective threshold of 50.0. This is a loader-level reproduction, not a second live rejection/acceptance experiment.

The numeric defaults matched our intended gates during the completed round, so this does not show that a model was wrongly accepted in that run. It shows that a model owner's non-default policy can be ignored.

Proposed scope

Choose and document one canonical field across manifests and consumers. If supporting the old name, define explicit precedence or reject conflicting values. Validate policy shape and test non-default values through the auditor service. Align the stale legacy_mean_until_contract_v2 metadata with the median already used on-chain; do not change the contract aggregation rule as part of this fix.

Acceptance criteria
  • Changing audit_scoring_policy.metrics.thresholds.min_accuracy changes the policy used by both reference auditors.
  • A known model passes/fails as expected under two deliberately different thresholds.
  • Missing fields, legacy aliases, conflicting fields and malformed policies have documented behavior.
  • GI pass-score configuration and auditor eligibility policy remain distinct, intentional controls.
  • Example manifests and documentation describe the effective median rule.
Full-round test report

See Discussion #331 — Fashion-MNIST with three notebooks and a Raspberry Pi for the setup diagram, completed protocol roles, results and experiment adaptations.

Vorherrschende Sprache
Python
Sterne
4
Forks
7
Ø Merge
5 T. 15 Std.
Gemergte PRs (30 T.)
43

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus InfiniteZeroFoundation/DevNet

Alle Issues in InfiniteZeroFoundation/DevNet

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.