gates: five things a review found beside #2464's boxes (a vacuous guard in the docs gate, the plants tool's row runner, a dropped red line, ten bare initialisers, an unreadable binary)
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 45/100
Direção de pesquisa
Read the five named checks in tools/docs_claims_check.sh, tools/phase2_plants.sh, tools/precheck.sh, src/builtins_int.c, src/trace.c, and tests/test_http_request_header.py; compare the plant row runner with tools/phase2_check.py and inspect the existing tests and build targets. Address each checkbox with a regression case or the stated closure rationale. Done means the listed behavior is verified or its explicit closure condition is met.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Found by the blind review of #2464 (four passes), beside the boxes of that change's six issues. None fails that change; each is true of phase2-numbers once #2464 is in.
Done when
-
tools/docs_claims_check.sh, the removed-text check: its "examined N text(s)" is the length of a constant tuple, and the guardif not filesafter it cannot fire for the file list the check builds. Either the count is of what was read (each text looked for in each file, counted where the comparison runs) and a planted empty file list turns the gate red, or the two lines are removed. -
tools/phase2_plants.sh,phase2_named_row: it runs a row differently fromtools/phase2_check.pyin five ways (it requires exit code 0 instead of reading the row's expected code; no time bound for a run; stdin not taken from/dev/null; one working folder shared across tiers; no witness check). Each fails loudly and none matters for the three rows it runs today. The runner calls the checker for one row, or the five are made the same and a row with an expected non-zero exit code is shown to run. -
tools/precheck.sh, the report: a line of a failing row's log that the red-line filter matches and that begins with#(tools/section_plan.shprints one) is shown today; an edit that drops such lines leaves the self-test green. The self-test's Python row prints one such line, or this is closed as not worth a case with the reason. -
src/builtins_int.c,src/trace.c: the ten view locals that #2462 initialised are writtenEigsView x = {{0}}; the tree hasEIGS_VIEW(name)for this, which adds a cleanup check. The ten use the macro, or a comment at the first says why not, and the riscv32 clang row still prints no-Wdefault-const-init-field-unsafeline. -
tests/test_http_request_header.py, rowQH17-leak: on a binary that can be run and not read, the row fails with[Errno 13] Permission denied(before #2464 it failed withcannot identify sanitizer build). No build target makes such a binary. Closed with that sentence, or the row says "cannot read the binary" by name.
— Claude DevBox
- Linguagem predominante
- C
- Estrelas
- 3
- Forks
- 7
- Merge médio
- 3h 28min
- PRs com merge (30d)
- 270
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Inclui um Dockerfile ou arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 83/100
InauguralSystems/EigenScript#2476 ·
Mantenedores costumam responder em até 1 dia
-
area:gates needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
InauguralSystems/EigenScript#2462 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameAbertaarea:gates kind:gate-defect needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
InauguralSystems/EigenScript#2461 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
area:gates kind:gate-defect needs-triage
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 86/100
InauguralSystems/EigenScript#2458 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordAbertaarea:http kind:silent-wrong
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
InauguralSystems/EigenScript#2394 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
Todas as issues de InauguralSystems/EigenScript
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 92/100
flipperdevices/flipperzero-firmware#4520 ·
Mantenedores costumam responder em até 1 dia
-
area/build-framework kind/enhancement priority/low
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 77/100
yugabyte/yugabyte-db#38826 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
meshcore-dev/MeshCore#3891 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
vlang/v#32675 · 1 comentário ·
Mantenedores costumam responder em até 1 dia