gates: five things a review found beside #2464's boxes (a vacuous guard in the docs gate, the plants tool's row runner, a dropped red line, ten bare initialisers, an unreadable binary)

Aperta
#2,479 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, python, shell
Ambito
testing, tooling

Direzione di ricerca

Read the five named checks in tools/docs_claims_check.sh, tools/phase2_plants.sh, tools/precheck.sh, src/builtins_int.c, src/trace.c, and tests/test_http_request_header.py; compare the plant row runner with tools/phase2_check.py and inspect the existing tests and build targets. Address each checkbox with a regression case or the stated closure rationale. Done means the listed behavior is verified or its explicit closure condition is met.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:gates found-by:critic kind:gate-defect

Found by the blind review of #2464 (four passes), beside the boxes of that change's six issues. None fails that change; each is true of phase2-numbers once #2464 is in.

Done when

  • tools/docs_claims_check.sh, the removed-text check: its "examined N text(s)" is the length of a constant tuple, and the guard if not files after it cannot fire for the file list the check builds. Either the count is of what was read (each text looked for in each file, counted where the comparison runs) and a planted empty file list turns the gate red, or the two lines are removed.
  • tools/phase2_plants.sh, phase2_named_row: it runs a row differently from tools/phase2_check.py in five ways (it requires exit code 0 instead of reading the row's expected code; no time bound for a run; stdin not taken from /dev/null; one working folder shared across tiers; no witness check). Each fails loudly and none matters for the three rows it runs today. The runner calls the checker for one row, or the five are made the same and a row with an expected non-zero exit code is shown to run.
  • tools/precheck.sh, the report: a line of a failing row's log that the red-line filter matches and that begins with # (tools/section_plan.sh prints one) is shown today; an edit that drops such lines leaves the self-test green. The self-test's Python row prints one such line, or this is closed as not worth a case with the reason.
  • src/builtins_int.c, src/trace.c: the ten view locals that #2462 initialised are written EigsView x = {{0}}; the tree has EIGS_VIEW(name) for this, which adds a cleanup check. The ten use the macro, or a comment at the first says why not, and the riscv32 clang row still prints no -Wdefault-const-init-field-unsafe line.
  • tests/test_http_request_header.py, row QH17-leak: on a binary that can be run and not read, the row fails with [Errno 13] Permission denied (before #2464 it failed with cannot identify sanitizer build). No build target makes such a binary. Closed with that sentence, or the row says "cannot read the binary" by name.

— Claude DevBox

Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 28m
PR unite (30g)
270

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.