gates: five things a review found beside #2464's boxes (a vacuous guard in the docs gate, the plants tool's row runner, a dropped red line, ten bare initialisers, an unreadable binary)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
Direzione di ricerca
Read the five named checks in tools/docs_claims_check.sh, tools/phase2_plants.sh, tools/precheck.sh, src/builtins_int.c, src/trace.c, and tests/test_http_request_header.py; compare the plant row runner with tools/phase2_check.py and inspect the existing tests and build targets. Address each checkbox with a regression case or the stated closure rationale. Done means the listed behavior is verified or its explicit closure condition is met.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Found by the blind review of #2464 (four passes), beside the boxes of that change's six issues. None fails that change; each is true of phase2-numbers once #2464 is in.
Done when
-
tools/docs_claims_check.sh, the removed-text check: its "examined N text(s)" is the length of a constant tuple, and the guardif not filesafter it cannot fire for the file list the check builds. Either the count is of what was read (each text looked for in each file, counted where the comparison runs) and a planted empty file list turns the gate red, or the two lines are removed. -
tools/phase2_plants.sh,phase2_named_row: it runs a row differently fromtools/phase2_check.pyin five ways (it requires exit code 0 instead of reading the row's expected code; no time bound for a run; stdin not taken from/dev/null; one working folder shared across tiers; no witness check). Each fails loudly and none matters for the three rows it runs today. The runner calls the checker for one row, or the five are made the same and a row with an expected non-zero exit code is shown to run. -
tools/precheck.sh, the report: a line of a failing row's log that the red-line filter matches and that begins with#(tools/section_plan.shprints one) is shown today; an edit that drops such lines leaves the self-test green. The self-test's Python row prints one such line, or this is closed as not worth a case with the reason. -
src/builtins_int.c,src/trace.c: the ten view locals that #2462 initialised are writtenEigsView x = {{0}}; the tree hasEIGS_VIEW(name)for this, which adds a cleanup check. The ten use the macro, or a comment at the first says why not, and the riscv32 clang row still prints no-Wdefault-const-init-field-unsafeline. -
tests/test_http_request_header.py, rowQH17-leak: on a binary that can be run and not read, the row fails with[Errno 13] Permission denied(before #2464 it failed withcannot identify sanitizer build). No build target makes such a binary. Closed with that sentence, or the row says "cannot read the binary" by name.
— Claude DevBox
- Lingua principale
- C
- Stelle
- 3
- Fork
- 7
- Merge medio
- 3h 28m
- PR unite (30g)
- 270
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
InauguralSystems/EigenScript#2476 ·
I maintainer di solito rispondono entro 1 giorno
-
area:gates needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
InauguralSystems/EigenScript#2462 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameApertaarea:gates kind:gate-defect needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
InauguralSystems/EigenScript#2461 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area:gates kind:gate-defect needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
InauguralSystems/EigenScript#2458 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordApertaarea:http kind:silent-wrong
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
InauguralSystems/EigenScript#2394 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di InauguralSystems/EigenScript
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
flipperdevices/flipperzero-firmware#4520 ·
I maintainer di solito rispondono entro 1 giorno
-
area/build-framework kind/enhancement priority/low
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
yugabyte/yugabyte-db#38826 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
meshcore-dev/MeshCore#3891 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug grammar sev-3
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
BUG/MEDIUM: regex: worker SIGSEGV when a regex is applied to an empty body on libc-regex buildsApertastatus: needs-triage type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100