gates: five things a review found beside #2464's boxes (a vacuous guard in the docs gate, the plants tool's row runner, a dropped red line, ten bare initialisers, an unreadable binary)

Abierto
#2,479 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, python, shell
Área
testing, tooling

Línea de trabajo

Read the five named checks in tools/docs_claims_check.sh, tools/phase2_plants.sh, tools/precheck.sh, src/builtins_int.c, src/trace.c, and tests/test_http_request_header.py; compare the plant row runner with tools/phase2_check.py and inspect the existing tests and build targets. Address each checkbox with a regression case or the stated closure rationale. Done means the listed behavior is verified or its explicit closure condition is met.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:gates found-by:critic kind:gate-defect

Found by the blind review of #2464 (four passes), beside the boxes of that change's six issues. None fails that change; each is true of phase2-numbers once #2464 is in.

Done when

  • tools/docs_claims_check.sh, the removed-text check: its "examined N text(s)" is the length of a constant tuple, and the guard if not files after it cannot fire for the file list the check builds. Either the count is of what was read (each text looked for in each file, counted where the comparison runs) and a planted empty file list turns the gate red, or the two lines are removed.
  • tools/phase2_plants.sh, phase2_named_row: it runs a row differently from tools/phase2_check.py in five ways (it requires exit code 0 instead of reading the row's expected code; no time bound for a run; stdin not taken from /dev/null; one working folder shared across tiers; no witness check). Each fails loudly and none matters for the three rows it runs today. The runner calls the checker for one row, or the five are made the same and a row with an expected non-zero exit code is shown to run.
  • tools/precheck.sh, the report: a line of a failing row's log that the red-line filter matches and that begins with # (tools/section_plan.sh prints one) is shown today; an edit that drops such lines leaves the self-test green. The self-test's Python row prints one such line, or this is closed as not worth a case with the reason.
  • src/builtins_int.c, src/trace.c: the ten view locals that #2462 initialised are written EigsView x = {{0}}; the tree has EIGS_VIEW(name) for this, which adds a cleanup check. The ten use the macro, or a comment at the first says why not, and the riscv32 clang row still prints no -Wdefault-const-init-field-unsafe line.
  • tests/test_http_request_header.py, row QH17-leak: on a binary that can be run and not read, the row fails with [Errno 13] Permission denied (before #2464 it failed with cannot identify sanitizer build). No build target makes such a binary. Closed with that sentence, or the row says "cannot read the binary" by name.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.