gates: five things a review found beside #2464's boxes (a vacuous guard in the docs gate, the plants tool's row runner, a dropped red line, ten bare initialisers, an unreadable binary)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Read the five named checks in tools/docs_claims_check.sh, tools/phase2_plants.sh, tools/precheck.sh, src/builtins_int.c, src/trace.c, and tests/test_http_request_header.py; compare the plant row runner with tools/phase2_check.py and inspect the existing tests and build targets. Address each checkbox with a regression case or the stated closure rationale. Done means the listed behavior is verified or its explicit closure condition is met.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Found by the blind review of #2464 (four passes), beside the boxes of that change's six issues. None fails that change; each is true of phase2-numbers once #2464 is in.
Done when
-
tools/docs_claims_check.sh, the removed-text check: its "examined N text(s)" is the length of a constant tuple, and the guardif not filesafter it cannot fire for the file list the check builds. Either the count is of what was read (each text looked for in each file, counted where the comparison runs) and a planted empty file list turns the gate red, or the two lines are removed. -
tools/phase2_plants.sh,phase2_named_row: it runs a row differently fromtools/phase2_check.pyin five ways (it requires exit code 0 instead of reading the row's expected code; no time bound for a run; stdin not taken from/dev/null; one working folder shared across tiers; no witness check). Each fails loudly and none matters for the three rows it runs today. The runner calls the checker for one row, or the five are made the same and a row with an expected non-zero exit code is shown to run. -
tools/precheck.sh, the report: a line of a failing row's log that the red-line filter matches and that begins with#(tools/section_plan.shprints one) is shown today; an edit that drops such lines leaves the self-test green. The self-test's Python row prints one such line, or this is closed as not worth a case with the reason. -
src/builtins_int.c,src/trace.c: the ten view locals that #2462 initialised are writtenEigsView x = {{0}}; the tree hasEIGS_VIEW(name)for this, which adds a cleanup check. The ten use the macro, or a comment at the first says why not, and the riscv32 clang row still prints no-Wdefault-const-init-field-unsafeline. -
tests/test_http_request_header.py, rowQH17-leak: on a binary that can be run and not read, the row fails with[Errno 13] Permission denied(before #2464 it failed withcannot identify sanitizer build). No build target makes such a binary. Closed with that sentence, or the row says "cannot read the binary" by name.
— Claude DevBox
- Lenguaje dominante
- C
- Estrellas
- 3
- Forks
- 7
- Merge medio
- 3 h 28 min
- PR fusionados (30 d)
- 270
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de InauguralSystems/EigenScript
-
area:gates kind:gate-defect
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
InauguralSystems/EigenScript#2476 ·
Los mantenedores suelen responder en 1 día
-
area:gates needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
InauguralSystems/EigenScript#2462 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
The hosted-RNG check refuses a clean tree that has a tracked file with a double quote in its nameAbiertoarea:gates kind:gate-defect needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
InauguralSystems/EigenScript#2461 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area:gates kind:gate-defect needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
InauguralSystems/EigenScript#2458 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
`http_post`: `headers` text with something after its JSON value now means no headers, without a wordAbiertoarea:http kind:silent-wrong
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
InauguralSystems/EigenScript#2394 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de InauguralSystems/EigenScript
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
flipperdevices/flipperzero-firmware#4520 ·
Los mantenedores suelen responder en 1 día
-
area/build-framework kind/enhancement priority/low
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
yugabyte/yugabyte-db#38826 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
meshcore-dev/MeshCore#3891 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug grammar sev-3
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
BUG/MEDIUM: regex: worker SIGSEGV when a regex is applied to an empty body on libc-regex buildsAbiertostatus: needs-triage type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100