Herb items with see-through leaves are drawn solid

Aberta
#485 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
csharp, unity

Direção de pesquisa

Start at VobInitializerDomain.CreateItemMesh and trace how useTextureArray: false leads to AbstractMeshBuilder.GetDefaultMaterial selecting Lit/SingleMesh; compare this with the bushes and trees that use Lit/AlphaToCoverage. The issue leaves the implementation choice open: a single-texture cutout variant or placing items in texture arrays. Done means the listed G2 herb textures with alpha render with cutout leaves, while textures without alpha retain their original solid appearance.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug
Description

Items are built without the texture arrays (VobInitializerDomain.CreateItemMesh, useTextureArray: false). AbstractMeshBuilder.GetDefaultMaterial then always gives them Lit/SingleMesh, which has no alpha test. The transparent parts of item textures with alpha are drawn solid.

Expected Behavior

Leaves are cut out like on bushes and trees (Lit/AlphaToCoverage).

Actual Behavior

Solid leaf quads. Affected G2 herbs (their leaf textures are DXT3, checked in the archives): ItPl_Health_Herb_03, ItPl_Dex_Herb_01, ItPl_Forestberry, ItPl_Planeberry, ItPl_Beet, ItPl_SwampHerb, ItPl_Weed, ItPl_Temp_Herb.
Herbs using ITFOOD-C.TEX (DXT1 without any alpha: healing, mana, speed, strength herbs, mushrooms) are solid in the original too.

Reproduction Steps
  1. G2, find or spawn ItPl_Health_Herb_03 or ItPl_SwampHerb.
  2. Look at the leaves.

Environment Information

  • Reproducibility: Always
  • Platform: all (seen on Quest 3)
  • Game Version: main 83a1aebd2
Notes

Not covered by BoroBongo's work: his palm leaf fix (EnableTextureArraySubmeshMaterials, experimental branch) only covers meshes that use the texture arrays.
Fix idea: a cutout variant for meshes with a single 2D texture, or items in the texture arrays.

Linguagem predominante
C#
Estrelas
33
Forks
1
Merge médio
1d 21h
PRs com merge (30d)
56

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de Gothic-Unity-Project/Gothic-Unity

Todas as issues de Gothic-Unity-Project/Gothic-Unity

Issues semelhantes

Mais issues de C#

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.