GPUI playback hitches during background edits on long recordings

Fechada
  • Algo errado?
#2,506 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Um pull request relacionado já foi integrado.

  • #2507 de @AksharP5 — integrado

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
45/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
desktop, performance

Direção de pesquisa

Start in crates/editor/src/playback.rs, in the project-watch branch that unconditionally rebuilds the cursor timelines, and check which inputs the constructor reads (raw mode and effective movement/click spring parameters). Then look at apps/desktop-gpui/src/editor_window.rs::publish_project to see how live updates reach that branch. Done means padding-only updates reuse the existing timelines while spring-parameter changes still rebuild them, verified with the playback benchmark described in the issue.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Description

Changing background padding or other unrelated project settings while GPUI playback runs can interrupt frame delivery on long recordings. The editor watch-update handler reconstructs cursor timelines for every project update, rerunning the movement/click spring simulation across all recording sources even when its inputs have not changed.

Reproduction
  1. Open a long recording with cursor movement and cursor smoothing enabled in the GPUI editor.
  2. Start playback and adjust background padding repeatedly.
  3. Frame delivery can hitch while the cursor simulation is rebuilt. Padding does not change the simulation inputs.

Confirmed with the production playback benchmark using a synthetic one-hour recording, 216,001 mouse moves at 60 Hz, a 480×270 preview at 60 fps, and padding updates at 10 Hz. Three runs each delivered 300 callbacks; median p95 callback gap was 44.77 ms with 55 playback skips per run. Reusing the timelines for unrelated edits reduced it to 17.83 ms and zero skips. Changing a spring parameter still triggers reconstruction.

Additional Context
  • Cap version: main 3d19c5cfa5e636107e78adde6d55be78404d4f23, GPUI playback engine.
  • OS: Arch Linux x86_64.
  • Device: Intel i5-14400F; benchmark used llvmpipe software Vulkan, Rust 1.88 and FFmpeg 7.1.

The measurement uses the actual editor playback/render callback path used by GPUI; it does not measure display presentation. Hardware GPU timing is unverified because this machine has mismatched installed and loaded NVIDIA driver versions.

apps/desktop-gpui/src/editor_window.rs::publish_project sends live updates during playback. crates/editor/src/playback.rs unconditionally rebuilds the timelines in its project-watch branch. The constructor depends on raw mode and effective movement/click spring parameters, not background padding.

Linguagem predominante
Rust
Estrelas
24.2k
Forks
2.2k
Merge médio
1d 9h
PRs com merge (30d)
731

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CapSoftware/Cap

Todas as issues de CapSoftware/Cap

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.