sim fails stringTest
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend, internationalization
Research direction
Run the sim with stringTest=double, stringTest=long, and stringTest=X to reproduce the checklist failures shown in the screenshots. Inspect AmpPhaseAccordionBox around line 166 and the affected layout components to identify strings and layout behavior that need attention. Done means the sim handles the listed string lengths and the omega symbol's translation status is resolved.
Written by the indexing model from the issue text.
Description
Related to #2 (code review).
The sim currently fails these stringTest checklist items in the code review:
Does the sim layout gracefully handle internationalized strings that are twice as long as the English strings? (run with query parameter stringTest=double)
Does the sim layout gracefully handle internationalized strings that are exceptionally long? (run with query parameter stringTest=long)
E.g. with ?stringTest=long:
This checklist item is also questionable:
- Are there any strings that are not internationalized, and does the sim layout gracefully handle internationalized strings that are shorter than the English strings? (run with query parameter stringTest=X. You should see nothing but 'X' strings.)
The omega symbol ω is not translatable (see AmpPhaseAccordionBox line 166). Should it be? E.g. with ?stringTest=X:
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/normal-modes
-
dev:typescript priority:5-deferred
Difficulty 5/5 Over a week Newbie friendliness 15/100
phetsims/normal-modes#92 ·
-
status:blocks-sim-publication
Difficulty 1/5 Under an hour Newbie friendliness 55/100
phetsims/normal-modes#90 ·
-
dev:code-review
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
phetsims/normal-modes#89 ·
-
priority:5-deferred type:bug type:multitouch
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#87 · 1 comment ·
-
priority:5-deferred type:performance
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#84 · 1 comment ·
All issues in phetsims/normal-modes
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Design only Leadership Survey SLFS
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
bcgov/digital-journeys#2293 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
tursodatabase/turso#9405 ·
Maintainers usually reply within 1 day
-
Toolkit
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
API Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ProjectSidewalk/SidewalkWebpage#5556 ·
Maintainers usually reply within 1 day