Misleading names for "number of masses"
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 58/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
Research direction
Locate NormalModesConstants and NormalModesModel, then trace references to numberOfMassesProperty and NUMBER_OF_MASSES_RANGE, especially in the Two Dimensions screen. Confirm that the values represent masses per row, rename the constants and property accordingly, update their documentation and references, and run the relevant project tests.
Written by the indexing model from the issue text.
Description
"Number of mass" seems to actually be the "number of masses per row". Confirm and rename these things:
In NormalModesConstants:
NUMBER_OF_MASSES_RANGE: NUMBER_OF_MASSES_RANGE, //TODO actually number of masses PER ROW
In NormalModesModel:
// @public {Property.<number>} the current number of visible masses
//TODO this is actually the number of masses per row. In the 'Two Dimensions' screen, the number of masses is this value squared. https://github.com/phetsims/tasks/issues/1129
this.numberOfMassesProperty = new NumberProperty( options.numberOfMasses, {
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phetsims/normal-modes
-
dev:typescript priority:5-deferred
Difficulty 5/5 Over a week Newbie friendliness 15/100
phetsims/normal-modes#92 ·
-
status:blocks-sim-publication
Difficulty 1/5 Under an hour Newbie friendliness 55/100
phetsims/normal-modes#90 ·
-
priority:5-deferred type:bug type:multitouch
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#87 · 1 comment ·
-
priority:5-deferred type:performance
Difficulty 3/5 1-2 days Newbie friendliness 42/100
phetsims/normal-modes#84 · 1 comment ·
-
Multitouch supportOpenpriority:5-deferred type:multitouch
Difficulty 5/5 Over a week Newbie friendliness 20/100
phetsims/normal-modes#80 ·
All issues in phetsims/normal-modes
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
curriculum documentation quality
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
githubnext/gh-aw-workshop#3897 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
agent/quality hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
Maintainers usually reply within 1 day