Launcher: install, repair and update can delete or overwrite a file replaced after the backup

Open
#185 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
desktop

Research direction

Start with the install, repair and update paths in clean/installer/src/wg_core/install.cpp (lines 788-838) and the helpers in util.cpp (lines 120-149), where the backup is hashed and verified before the target is acted on by path. Trace where the disable target is deleted, the rename destination is removed, and MOVEFILE_REPLACE_EXISTING or CopyFileW(..., FALSE) is used. Done means the target is held or created fail-if-present through the action, so a file replaced after the backup is detected and kept, with race tests covering the whole operation.

Written by the indexing model from the issue text.

Description

area: launcher bug

Install, repair and update (clean/installer/src/wg_core/install.cpp:788-838, util.cpp:120-149) hash and verify a backup, then act on the target by path: they delete a disable target, delete a rename destination, and write payloads with MOVEFILE_REPLACE_EXISTING or CopyFileW(..., FALSE).

If another program replaces the target after the backup, or creates a target that was absent, the new file is deleted or overwritten while the backup holds the old bytes. This also covers repair and update after a restore, and the FSR rename-aside.

Expected: hold and verify the destination through the action (one handle), or create with fail-if-present, so a replacement is detected and kept. Needs race tests across the whole operation.

Found in the review of #47.

Dominant language
C++
Stars
12
Forks
2
Avg merge
3h 10m
Merged PRs (30d)
171

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phantoslayer21/wronggpu

All issues in phantoslayer21/wronggpu

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.