Rebase our react-data-grid fork onto current upstream

Open
#10,611 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
12/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
git, javascript, postgresql, react

Research direction

Start with web/package.json to find the pinned react-data-grid commit, then compare the fork commit 8ddaa7be against adazzle/react-data-grid at 7.0.0-beta.60. Look at the grid usages named in the issue (onSelectedCellChange, rdg-cell-copied, textEditor) in the Query Tool, View/Edit Data and schema dialog code. Done means the fork is rebased, pgAdmin's pin is updated, and the Jest and Selenium feature tests pass.

Written by the indexing model from the issue text.

Description

Housekeeping

pgAdmin installs react-data-grid from our fork, pgadmin-org/react-data-grid, pinned by commit in web/package.json. The fork is upstream 7.0.0-beta.58 plus one commit of our own (8ddaa7be, cell range selection), and is now about 255 commits behind adazzle/react-data-grid, which is at 7.0.0-beta.60. We should rebase the fork onto current upstream and update pgAdmin to match.

This isn't a fast-forward, as upstream has made breaking changes that affect both the fork commit and pgAdmin:

  • onSelectedCellChange (used in pgAdmin) is now onActivePositionChange, part of a selectedPosition to activePosition rename; selectCell, which the range selection code relies on, has changed too.
  • The rdg-cell-copied class, which pgAdmin styles, has been removed.
  • textEditor has been renamed to renderTextEditor.
  • Rows are now focusable and the focus sink element has been removed, which changes the keyboard and focus handling the range selection code is built on.
  • The build moved from rolldown to tsdown, and biome and the old ESLint setup were replaced.

So the work is: rebase the range selection commit (and the shift + click change from pgadmin-org/react-data-grid#9, if merged by then) onto upstream, rebuild lib/, bump the pin in pgAdmin, and update the Query Tool, View/Edit Data and schema dialog grids for the API changes. The Selenium feature tests need to pass as well as Jest, as grid problems in dialogs don't show up in the unit tests. In return we get upstream's fixes since beta.58 and React 19.3 support.

Dominant language
Python
Stars
3.9k
Forks
922
Avg merge
2d 3h
Merged PRs (30d)
33

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pgadmin-org/pgadmin4

All issues in pgadmin-org/pgadmin4

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.