Rebase our react-data-grid fork onto current upstream
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 12/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- git, javascript, postgresql, react
- Domain
- developer-experience, frontend
Research direction
Start with web/package.json to find the pinned react-data-grid commit, then compare the fork commit 8ddaa7be against adazzle/react-data-grid at 7.0.0-beta.60. Look at the grid usages named in the issue (onSelectedCellChange, rdg-cell-copied, textEditor) in the Query Tool, View/Edit Data and schema dialog code. Done means the fork is rebased, pgAdmin's pin is updated, and the Jest and Selenium feature tests pass.
Written by the indexing model from the issue text.
Description
pgAdmin installs react-data-grid from our fork, pgadmin-org/react-data-grid, pinned by commit in web/package.json. The fork is upstream 7.0.0-beta.58 plus one commit of our own (8ddaa7be, cell range selection), and is now about 255 commits behind adazzle/react-data-grid, which is at 7.0.0-beta.60. We should rebase the fork onto current upstream and update pgAdmin to match.
This isn't a fast-forward, as upstream has made breaking changes that affect both the fork commit and pgAdmin:
onSelectedCellChange(used in pgAdmin) is nowonActivePositionChange, part of aselectedPositiontoactivePositionrename;selectCell, which the range selection code relies on, has changed too.- The
rdg-cell-copiedclass, which pgAdmin styles, has been removed. textEditorhas been renamed torenderTextEditor.- Rows are now focusable and the focus sink element has been removed, which changes the keyboard and focus handling the range selection code is built on.
- The build moved from rolldown to tsdown, and biome and the old ESLint setup were replaced.
So the work is: rebase the range selection commit (and the shift + click change from pgadmin-org/react-data-grid#9, if merged by then) onto upstream, rebuild lib/, bump the pin in pgAdmin, and update the Query Tool, View/Edit Data and schema dialog grids for the API changes. The Selenium feature tests need to pass as well as Jest, as grid problems in dialogs don't show up in the unit tests. In return we get upstream's fixes since beta.58 and React 19.3 support.
- Dominant language
- Python
- Stars
- 3.9k
- Forks
- 922
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 33
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pgadmin-org/pgadmin4
-
Invalid syntax in sshtunnelPossibly taken A pull request linked to this issue is open or already merged. OpenBug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
pgadmin-org/pgadmin4#10797 ·
Maintainers usually reply within 2 days
-
Feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pgadmin-org/pgadmin4#10426 · 3 comments · 1 reaction ·
Maintainers usually reply within 2 days
-
Bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
pgadmin-org/pgadmin4#10796 · 1 comment ·
Maintainers usually reply within 2 days
-
Schema Diff does not detect foreign keys that reference a different schemaPossibly taken @dpage claimed this today. Open
Difficulty 4/5 3-5 days Newbie friendliness 57/100
pgadmin-org/pgadmin4#10786 · 1 assignee ·
Maintainers usually reply within 2 days
-
Bug
Difficulty 4/5 3-5 days Newbie friendliness 55/100
pgadmin-org/pgadmin4#10783 ·
Maintainers usually reply within 2 days
All issues in pgadmin-org/pgadmin4
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mohanraj00/entelos#200 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
sweep
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
bketelsen/truenas-mcp#77 ·
Maintainers usually reply within 1 day
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openedx/xblock-lti-consumer#765 ·
Maintainers usually reply within 1 day