Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Rebase our react-data-grid fork onto current upstream

Aperta
  • Qualcosa non va?
#10,611 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
12/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
git, javascript, postgresql, react
Ambito
developer-experience, frontend

Direzione di ricerca

Start with web/package.json to find the pinned react-data-grid commit, then compare the fork commit 8ddaa7be against adazzle/react-data-grid at 7.0.0-beta.60. Look at the grid usages named in the issue (onSelectedCellChange, rdg-cell-copied, textEditor) in the Query Tool, View/Edit Data and schema dialog code. Done means the fork is rebased, pgAdmin's pin is updated, and the Jest and Selenium feature tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Housekeeping

pgAdmin installs react-data-grid from our fork, pgadmin-org/react-data-grid, pinned by commit in web/package.json. The fork is upstream 7.0.0-beta.58 plus one commit of our own (8ddaa7be, cell range selection), and is now about 255 commits behind adazzle/react-data-grid, which is at 7.0.0-beta.60. We should rebase the fork onto current upstream and update pgAdmin to match.

This isn't a fast-forward, as upstream has made breaking changes that affect both the fork commit and pgAdmin:

  • onSelectedCellChange (used in pgAdmin) is now onActivePositionChange, part of a selectedPosition to activePosition rename; selectCell, which the range selection code relies on, has changed too.
  • The rdg-cell-copied class, which pgAdmin styles, has been removed.
  • textEditor has been renamed to renderTextEditor.
  • Rows are now focusable and the focus sink element has been removed, which changes the keyboard and focus handling the range selection code is built on.
  • The build moved from rolldown to tsdown, and biome and the old ESLint setup were replaced.

So the work is: rebase the range selection commit (and the shift + click change from pgadmin-org/react-data-grid#9, if merged by then) onto upstream, rebuild lib/, bump the pin in pgAdmin, and update the Query Tool, View/Edit Data and schema dialog grids for the API changes. The Selenium feature tests need to pass as well as Jest, as grid problems in dialogs don't show up in the unit tests. In return we get upstream's fixes since beta.58 and React 19.3 support.

Lingua principale
Python
Stelle
3.9k
Fork
910
Merge medio
1g 6h
PR unite (30g)
38

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pgadmin-org/pgadmin4

Tutte le issue di pgadmin-org/pgadmin4

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.