Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Rebase our react-data-grid fork onto current upstream

Abierto
#10,611 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
12/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
git, javascript, postgresql, react

Línea de trabajo

Start with web/package.json to find the pinned react-data-grid commit, then compare the fork commit 8ddaa7be against adazzle/react-data-grid at 7.0.0-beta.60. Look at the grid usages named in the issue (onSelectedCellChange, rdg-cell-copied, textEditor) in the Query Tool, View/Edit Data and schema dialog code. Done means the fork is rebased, pgAdmin's pin is updated, and the Jest and Selenium feature tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Housekeeping

pgAdmin installs react-data-grid from our fork, pgadmin-org/react-data-grid, pinned by commit in web/package.json. The fork is upstream 7.0.0-beta.58 plus one commit of our own (8ddaa7be, cell range selection), and is now about 255 commits behind adazzle/react-data-grid, which is at 7.0.0-beta.60. We should rebase the fork onto current upstream and update pgAdmin to match.

This isn't a fast-forward, as upstream has made breaking changes that affect both the fork commit and pgAdmin:

  • onSelectedCellChange (used in pgAdmin) is now onActivePositionChange, part of a selectedPosition to activePosition rename; selectCell, which the range selection code relies on, has changed too.
  • The rdg-cell-copied class, which pgAdmin styles, has been removed.
  • textEditor has been renamed to renderTextEditor.
  • Rows are now focusable and the focus sink element has been removed, which changes the keyboard and focus handling the range selection code is built on.
  • The build moved from rolldown to tsdown, and biome and the old ESLint setup were replaced.

So the work is: rebase the range selection commit (and the shift + click change from pgadmin-org/react-data-grid#9, if merged by then) onto upstream, rebuild lib/, bump the pin in pgAdmin, and update the Query Tool, View/Edit Data and schema dialog grids for the API changes. The Selenium feature tests need to pass as well as Jest, as grid problems in dialogs don't show up in the unit tests. In return we get upstream's fixes since beta.58 and React 19.3 support.

Lenguaje dominante
Python
Estrellas
3.9k
Forks
910
Merge medio
1 d 6 h
PR fusionados (30 d)
37

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pgadmin-org/pgadmin4

Todos los issues de pgadmin-org/pgadmin4

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.