Issues to address in pgr_contractionHierarchies before promotion from experimental status
Maintainers usually reply within 3 days
@cvvergara is already working on this.
Since Apr 25, 2025.
Assessment
This issue has not been assessed yet.
Description
Issues to Address for pgr_contractionHierarchies
This issue tracks the remaining work needed for PR #2868: New function pgr contraction hierarchies 3.8 by @cvvergara before the pgr_contractionHierarchies function can be promoted from experimental to proposed status.
Background
The pgr_contractionHierarchies function was added as experimental as it still has various issues that need to be resolved. As noted in the PR discussion:
The function is added as experimental as it still has a lot of issues, some are noticed by the rabbit, others are for code organization. When the issues are fixed then we can promote to proposed.
Issues to Address
Based on the PR reviews and comments, the following issues need to be addressed:
Code Organization Issues
- Review and improve the organization of code files
- Ensure proper code structure for maintainability
- Apply consistent coding style across implementation
CodeRabbit-Identified Issues
- Fix potential memory leak in
result_tupleswhenSRF_RETURN_DONEis reached - Review and fix issues with negative
reverse_costin shortcut edges - Fix template argument from visitor instantiation in contractionHierarchies.hpp
- Guard against empty priority-queue before calling
top() - Review parameter passing in no_crash_test.pg
- Consider adding metric values for shortcut edges
Documentation & Tests
- Ensure all test plans accurately match the number of assertions
- Update documentation to clearly explain the function's experimental status and caveats
- Add additional examples showing integration with other algorithms
Action Plan
- Address code organization issues first
- Fix implementation bugs identified by code review
- Improve tests and documentation
- Verify all issues are resolved
- Promote the function from experimental to proposed status
References
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 397
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 8
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pgRouting/pgrouting
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 3 days
-
Administrative Enhancement
Difficulty 1/5 Under an hour Newbie friendliness 80/100
Maintainers usually reply within 3 days
-
points_input Developers docPossibly taken @withaman69 claimed this 101 days ago. OpenC/C++ Developers Doc. good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pgRouting/pgrouting#973 · 10 comments ·
Maintainers usually reply within 3 days
-
get_check_data developers docPossibly taken @withaman69 claimed this 102 days ago. OpenC/C++ Developers Doc. good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pgRouting/pgrouting#972 · 7 comments ·
Maintainers usually reply within 3 days
All issues in pgRouting/pgrouting
Similar issues
-
std::fdim drops partial derivative w.r.t second argument in forward and reverse modePossibly taken @ADITYASINGH1206 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
vgvassilev/clad#2534 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
HAP.cpp fixOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
KLayout/klayout#2554 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day