Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Issues to address in pgr_contractionHierarchies before promotion from experimental status

Aperta
  • Qualcosa non va?
#2,870 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@cvvergara ci sta già lavorando.

Dal 25/4/2025.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Issues to Address for pgr_contractionHierarchies

This issue tracks the remaining work needed for PR #2868: New function pgr contraction hierarchies 3.8 by @cvvergara before the pgr_contractionHierarchies function can be promoted from experimental to proposed status.

Background

The pgr_contractionHierarchies function was added as experimental as it still has various issues that need to be resolved. As noted in the PR discussion:

The function is added as experimental as it still has a lot of issues, some are noticed by the rabbit, others are for code organization. When the issues are fixed then we can promote to proposed.

Issues to Address

Based on the PR reviews and comments, the following issues need to be addressed:

Code Organization Issues
  • Review and improve the organization of code files
  • Ensure proper code structure for maintainability
  • Apply consistent coding style across implementation
CodeRabbit-Identified Issues
  • Fix potential memory leak in result_tuples when SRF_RETURN_DONE is reached
  • Review and fix issues with negative reverse_cost in shortcut edges
  • Fix template argument from visitor instantiation in contractionHierarchies.hpp
  • Guard against empty priority-queue before calling top()
  • Review parameter passing in no_crash_test.pg
  • Consider adding metric values for shortcut edges
Documentation & Tests
  • Ensure all test plans accurately match the number of assertions
  • Update documentation to clearly explain the function's experimental status and caveats
  • Add additional examples showing integration with other algorithms

Action Plan

  1. Address code organization issues first
  2. Fix implementation bugs identified by code review
  3. Improve tests and documentation
  4. Verify all issues are resolved
  5. Promote the function from experimental to proposed status

References

Lingua principale
C++
Stelle
1.4k
Fork
397
Merge medio
2g 2h
PR unite (30g)
4

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pgRouting/pgrouting

Tutte le issue di pgRouting/pgrouting

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.