Issues to address in pgr_contractionHierarchies before promotion from experimental status

Abierto
  • ¿Algo no está bien?
#2,870 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@cvvergara ya está trabajando en esto.

Desde el 25/4/2025.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Issues to Address for pgr_contractionHierarchies

This issue tracks the remaining work needed for PR #2868: New function pgr contraction hierarchies 3.8 by @cvvergara before the pgr_contractionHierarchies function can be promoted from experimental to proposed status.

Background

The pgr_contractionHierarchies function was added as experimental as it still has various issues that need to be resolved. As noted in the PR discussion:

The function is added as experimental as it still has a lot of issues, some are noticed by the rabbit, others are for code organization. When the issues are fixed then we can promote to proposed.

Issues to Address

Based on the PR reviews and comments, the following issues need to be addressed:

Code Organization Issues
  • Review and improve the organization of code files
  • Ensure proper code structure for maintainability
  • Apply consistent coding style across implementation
CodeRabbit-Identified Issues
  • Fix potential memory leak in result_tuples when SRF_RETURN_DONE is reached
  • Review and fix issues with negative reverse_cost in shortcut edges
  • Fix template argument from visitor instantiation in contractionHierarchies.hpp
  • Guard against empty priority-queue before calling top()
  • Review parameter passing in no_crash_test.pg
  • Consider adding metric values for shortcut edges
Documentation & Tests
  • Ensure all test plans accurately match the number of assertions
  • Update documentation to clearly explain the function's experimental status and caveats
  • Add additional examples showing integration with other algorithms

Action Plan

  1. Address code organization issues first
  2. Fix implementation bugs identified by code review
  3. Improve tests and documentation
  4. Verify all issues are resolved
  5. Promote the function from experimental to proposed status

References

Lenguaje dominante
C++
Estrellas
1.4k
Forks
397
Merge medio
2 d 2 h
PR fusionados (30 d)
4

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pgRouting/pgrouting

Todos los issues de pgRouting/pgrouting

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.