DataViewToolbar: Pagination misaligned from rest of toolbar

Open Beginner friendly
#692 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Start in packages/module/src/DataViewToolbar/DataViewToolbar.tsx at the pagination wrapper referenced in the issue, then compare the component behavior with the DataViewToolbar documentation examples. Confirm the fix by checking that pagination renders in the same row as the other toolbar content, matching the toolbar design guidelines.

Written by the indexing model from the issue text.

Description

Hey PatternFly team!😁

I was recently working with the DataViewToolbar component attempting to align the toolbar with the pagination in the same row. Currently, when passing a pagination prop to the component the pagination is not aligned in the same row as the rest of the toolbar. Example (and this same behavior is displayed in the examples in the component's docs):

Image

PatternFly's toolbar design guidelines recommend these be aligned in the same row.

After some investigation, I found the pagination is wrapped in a div that uses flex with a set width of 100%. This causes the pagination to render in its own row distinct from the rest of the toolbar. Link to code referenced

Please implement a fix that aligns the pagination in the same row as the rest of the toolbar. Thank you!😄

Jira Issue: PF-4529

Dominant language
TypeScript
Stars
4
Forks
21
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/react-data-view

All issues in patternfly/react-data-view

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.