Initial Filters is not respected when array type filter

Open Beginner friendly
#671 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Start from the filter logic shown in the issue and trace how array filters and initialFilters are loaded when the URL key is absent. Reproduce the case with an array type filter and verify that the configured initial values are retained when no URL values exist.

Written by the indexing model from the issue text.

Description

When the user supplies an array type filter with initialFilters, the initialFilters are never used. The filter logic has the following code:

	  const urlValue = isArrayFilter ? searchParams?.getAll(key) : searchParams?.get(key);

      // eslint-disable-next-line no-nested-ternary
      loadedFilters[key] = urlValue
        ? (isArrayFilter && !Array.isArray(urlValue) ? [ urlValue ] : urlValue)
        : initialFilters[key];

The issue is that searchParams.getAll returns an empty array when key doesn't exist, so the truthy check on urlValue evaluates to true even though nothing is set.

This can be resolved by checking the length of the array when isArrayFilter is true

Jira Issue: PF-4302

Dominant language
TypeScript
Stars
4
Forks
21
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/react-data-view

All issues in patternfly/react-data-view

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.