Consistency: Add chip toolbar buttons to all DataView filters to match TreeViewFilter

Open
#646 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Start by comparing DataViewTreeViewFilter with the other data-view filters and review the linked PatternFly filter examples. Update the remaining filters to provide the same chip-toolbar button behavior, then verify that all data-view filter variants are consistent.

Written by the indexing model from the issue text.

Description

Hello,

During a recent PR review, we noticed that the DataViewTreeViewFilter contains an extra button in the chip toolbar that isn't present in other data-view filters:

Image

This is, however, as per the examples I found in PatternFly documentation, the correct behaviour for filters:

Image

Could you please implement this behaviour to the rest of the data-view filters?

Many thanks for considering the change!

Jira Issue: PF-4106

Dominant language
TypeScript
Stars
4
Forks
21
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/react-data-view

All issues in patternfly/react-data-view

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.