New exports from `DataViewTh` hide type exported from `DataViewTable`

Open Beginner friendly
#662 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
react, typescript
Domain
frontend

Research direction

Inspect the export changes in the referenced commit and compare them with the existing DataViewTh type export from DataViewTable. Resolve the naming collision so DataViewTh remains usable as a type, then run the TypeScript build or relevant checks to confirm the TS2749 error is gone.

Written by the indexing model from the issue text.

Description

Version 6.5 adds new exports from DataviewTh, but this hides the DataViewTh type already exported from DataViewTable [1]. This results in build errors due to the type/const mismatch.

error TS2749: 'DataViewTh' refers to a value, but is being used as a type here. Did you mean 'typeof DataViewTh'?

[1] https://github.com/patternfly/react-data-view/commit/16bc87dd31b9a0802effc7e7349cad8d9b1f985f#diff-146876574627e7fb43f6b4c0af8c98e89b44660c64fc8522d032afea5cd797e1

Jira Issue: PF-4240

Dominant language
TypeScript
Stars
4
Forks
21
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from patternfly/react-data-view

All issues in patternfly/react-data-view

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.