Characters should stop their win / lose sound when the next match starts

Open
#643 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
lua
Domain
game-dev

Research direction

Start by tracing how characters are loaded and how win/lose sounds are played, then follow what happens when the next match starts. The issue raises two possible approaches but does not choose one; clarify how sounds remain reachable when characters are replaced. Done means win/lose sounds from the previous match stop when the next match begins.

Written by the indexing model from the issue text.

Description

bug Client-side priority: 3 - wishlist sound

This is kind of tricky because we might not really have a reference to the character if a new character has been loaded.

Should we cycle through all loaded characters and stop their sounds?

Should we hold a reference of playing sounds?

Dominant language
Lua
Stars
30
Forks
20
Avg merge
3d 15h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from panel-attack/panel-game

All issues in panel-attack/panel-game

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.